Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for selecting subject(s) by position after randomization #352

Merged
merged 4 commits into from
Aug 13, 2020

Conversation

36000
Copy link
Collaborator

@36000 36000 commented Aug 12, 2020

This will be useful with cloudknot. For example, imagine I want to use cloudknout to process 3 random subjects. Each process can use the same random seed, but be told to use either the first, second, or third subject out of the randomized list of subjects generated from the same seed.

@36000 36000 changed the title Allow for spefic subject to be selected by its position after randomization [WIP] Allow for spefic subject to be selected by its position after randomization Aug 12, 2020
@36000 36000 changed the title [WIP] Allow for spefic subject to be selected by its position after randomization [WIP] Allow for specific subject to be selected by its position after randomization Aug 12, 2020
@36000 36000 changed the title [WIP] Allow for specific subject to be selected by its position after randomization [WIP] Allow for selecting subject(s) by position after randomization Aug 12, 2020
@36000 36000 changed the title [WIP] Allow for selecting subject(s) by position after randomization Allow for selecting subject(s) by position after randomization Aug 12, 2020
@36000
Copy link
Collaborator Author

36000 commented Aug 12, 2020

@richford what do you think of this? I don't want to overcomplicate the function so I can put this elsewhere if you like.

@36000 36000 force-pushed the random_subjects_wo_replacement branch 2 times, most recently from 2b19739 to d7fe972 Compare August 13, 2020 01:54
Copy link
Collaborator

@richford richford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made one small suggestion for sorting _all_subjects. Other than that, LGTM! 🚀

AFQ/data.py Outdated Show resolved Hide resolved
@36000 36000 force-pushed the random_subjects_wo_replacement branch from 9e50fbe to db9b013 Compare August 13, 2020 19:26
@richford
Copy link
Collaborator

Thanks @36000 for sorting _all_subjects. IMO, this is ready to go now...you or @arokem can merge after tests pass! 🚀

@arokem
Copy link
Collaborator

arokem commented Aug 13, 2020

Now you can too! :shipit:

@36000 36000 merged commit 3f93cc2 into yeatmanlab:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants