Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw error when backend is misnamed #363

Merged
merged 6 commits into from
Aug 14, 2020
Merged

Throw error when backend is misnamed #363

merged 6 commits into from
Aug 14, 2020

Conversation

36000
Copy link
Collaborator

@36000 36000 commented Aug 14, 2020

Closes #362

arokem
arokem reviewed Aug 14, 2020
View reviewed changes
AFQ/viz/utils.py Outdated Show resolved Hide resolved
@arokem
Copy link
Collaborator

arokem commented Aug 14, 2020

Also, adding a test that __init__ indeed raises an error when you enter "plotlyy" or somesuch would be good.

@36000 @arokem
tell user what value they used
52828c2 
Co-authored-by: Ariel Rokem <arokem@gmail.com>
@pep8speaks
Copy link

pep8speaks commented Aug 14, 2020 •
edited

Hello @36000! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-08-14 20:27:27 UTC

arokem
arokem reviewed Aug 14, 2020
View reviewed changes
AFQ/tests/test_viz.py Outdated Show resolved Hide resolved
@arokem arokem merged commit b27e9f1 into yeatmanlab:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arokem arokem arokem left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add error handling for viz backend typos
3 participants
@36000 @arokem @pep8speaks