Catch no subject error early #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36000
changed the title
|
Any chance to add a test of this? |
36000
changed the title
36000
force-pushed
the
catch_gtab_err_early
branch
from
b5aa61a
to
40964b9
Compare
arokem
reviewed
Sep 22, 2020
| @@ -180,6 +180,23 @@ def test_AFQ_custom_tract(): | |||
|
|
|||
|
|
|||
| @pytest.mark.nightly2 | |||
| def test_AFQ_no_derivs(): | |||
There was a problem hiding this comment.
Should this test really be marked as nightly? It probably runs pretty quickly (?)
There was a problem hiding this comment.
test_AFQ_init is also marked nightly. Initializing an afq object takes about a minute I think, and if we have a lot of these tests, they can add up. To reduce time to make afq object, see: #448
There was a problem hiding this comment.
OK - that makes sense. Merging!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.