ENH #443 Callosal Group Example #476
Conversation
| f'afq_{bundle}_density_map.nii.gz')) | ||
| show_anatomical_slices(tractogram_img.get_fdata(), | ||
| f'Cleaned {bundle} Density Map') | ||
|
|
There was a problem hiding this comment.
Maybe add an html/plotly visualization with the resulting segmented bundle?
There was a problem hiding this comment.
Use AFQ.viz.plotly_backend function for showing streamlines. This should generate an HTML file that you can then incorporate here using:
plotly.io.show(html_file_name)
There was a problem hiding this comment.
Addressed, but depends on #513
There was a problem hiding this comment.
Looks like that's been merged. Could you please rebase on top of master one more time?
There was a problem hiding this comment.
Oh - nevermind. Looks like it's working. I'll go ahead and merge.
|
Looks like a few other commits got convolved in with your commits. Could you please rebase? |
bloomdt-uw
force-pushed
the
enh/443-callosal-group-example
branch
3 times, most recently
from
61cc797
to
d9dd200
Compare
|
Hello @bloomdt-uw! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-10-06 23:52:31 UTC |
bloomdt-uw
force-pushed
the
enh/443-callosal-group-example
branch
11 times, most recently
from
defe752
to
f1cd095
Compare
Co-authored-by: Adam Richie-Halford <richford@users.noreply.github.com>
Co-authored-by: Ariel Rokem <arokem@gmail.com>
bloomdt-uw
force-pushed
the
enh/443-callosal-group-example
branch
from
56d740d
to
2ed4d85
Compare
Baseline commit. There are several other enhancements requests and issues that will follow from work on this pull request. I think the main concern I have at the moment is whether the descriptive text is sufficiently accurate and any additional recommended text that would enhance the interpretive value the anatomical images, ROIs, or streamline density maps. I will add few comments in the pull request to address specific areas of interest and concern. From this conversation, I will open separate issues and enhancement requests where needed.