Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Put tg in rasmm first for SLR registration #566

Merged
merged 2 commits into from
Oct 29, 2020
Merged

[FIX] Put tg in rasmm first for SLR registration #566

merged 2 commits into from
Oct 29, 2020

Conversation

36000
Copy link
Collaborator

@36000 36000 commented Oct 21, 2020 •
edited

I think that SLR registration in pyAFQ with waypoint ROI segmentation has always had this problem. It works significantly better with this fixed.

Note: SLR with recobundles is handled elsewhere and did not have this bug, only SLR with waypoint ROI approach has this bug.

@pep8speaks
Copy link

pep8speaks commented Oct 21, 2020 •
edited

Hello @36000! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-10-21 19:28:55 UTC

@36000 36000 changed the title [WIP] [FIX] Put tg in rasmm first for SLR registration [FIX] Put tg in rasmm first for SLR registration Oct 21, 2020
@36000
Copy link
Collaborator Author

36000 commented Oct 27, 2020

@arokem this is ready for review / merge

@arokem arokem merged commit 9aead57 into yeatmanlab:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@36000 @pep8speaks @arokem