-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Example that explores BIDS and includes tractography from another pipeline. #577
Conversation
I think there's something wonky with this trk file. I get:
|
Thanks for the comments. I think they're addressed in the last couple of commits, but let me know if you think I should be more specific about anything. |
On a bit of further thought, I think that this example could be expanded a bit to explain how/why we use BIDS more generally. Hopefully, I'll find some time to work on that tomorrow. And also to fix the failing test. |
examples/plot_other_tracking.py
Outdated
# | ├── sub-01_ses-01_dwi.bvals | ||
# | ├── sub-01_ses-01_dwi.bvecs | ||
# | └── sub-01_ses-01_dwi.nii.gz | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May want to identify any files that are under bids that cannot be located, do not conform to standards, and do not follow convention. If pybids doesn't support this we may want to open an issue.
In lieu can:
- run
bids-validator
- run
bids_layout.get()
and compare to anos.walk
- run
get_entities()
examples/plot_other_tracking.py
Outdated
bids_path, | ||
dmriprep='vistasoft', | ||
bundle_info=bundle_info, | ||
custom_tractography_bids_filters={ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May want to include primer on how to configure/diagnose bids_filters:
bids_layout = BIDSLayout(BIDS_DIR, derivatives=True)
# find all files
bids_layout.files
# get a specific file; probably want to specify full path
bids_layout.get()
# find out what entities are available for bids filters for file
bids_layout.get().get_entities()
Some issues have been dataset_description.json
, file naming convention doesn't uniquely identify file with bids filters, ...
Hello @arokem! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-11-19 06:22:47 UTC |
Also, addresses comments/suggestions.
b1a27a5
to
8de3d76
Compare
Reading this and the comments again, I think that maybe this is enough for now? I think that a more detailed tutorial on BIDS/pyBIDS is out of scope for us, and users can get more information from the pybids documentation. So, I think this is ready for another review and potentially even merge. |
LGTM! |
@jyeatman : this is the example that shows how to use tractography outputs from another pipeline