New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Traverse BIDS hierarchy to find masks, bvals, and bvecs #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ierarchy to find masks, bvals, and bvecs
richford
added
bug
enhancement
effort: medium
A medium amount of effort needed to resolve this issue
impact: high
High impact issues that will really improve the project
labels
Nov 3, 2020
36000
reviewed
Nov 4, 2020
I changed some of the nighlty smoke tests to run tractography when testing tractography related things. If this runs into emmory errors I can reduce number of seeds, but that should be in a different PR. These new tests would have been able to trigger your error, I think. |
…(). get_nearest will still match the session entity and return the same session if it is indeed nearest. However, leaving it out of the explicit get_nearest() params, will allow masks that are not in the dwi session.
… fix/bids-inheritance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
effort: medium
A medium amount of effort needed to resolve this issue
enhancement
impact: high
High impact issues that will really improve the project
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR traverses the BIDS hierarchy to find masks, bval files, and bvec files instead of assuming that they will be found in the same session. It is part bugfix, part enhancement because it also fixes the underscore error in
PFTMask.get_mask()
.Traversing the hierarchy should allow it to interact with common output patterns from nipreps.