Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more timing information #622

Merged
merged 3 commits into from
Jan 4, 2021
Merged

Add more timing information #622

merged 3 commits into from
Jan 4, 2021

Conversation

36000
Copy link
Collaborator

@36000 36000 commented Dec 28, 2020

Specifically, pre-registration takes ~5x longer than mapping on pre-K data, so it needs to be in the timing file.

@pep8speaks
Copy link

pep8speaks commented Dec 28, 2020 •
edited

Hello @36000! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-01-04 21:48:37 UTC

@36000 36000 added this to the Version 0.6 milestone Dec 28, 2020
@36000
Copy link
Collaborator Author

36000 commented Jan 4, 2021

Change commas to underscores

arokem
arokem reviewed Jan 4, 2021
View reviewed changes
AFQ/api.py Outdated Show resolved Hide resolved
@arokem arokem merged commit e2b4234 into yeatmanlab:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arokem arokem arokem left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@36000 @pep8speaks @arokem