Bvals preallocation #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think there is anything special about that one. I think that we assumed that the meta-data will be similar across all the nifti files, and we are keeping this around, so that we can get the affine transformation stored in the header of this file. For example: https://github.com/yeatmanlab/pyAFQ/blob/master/AFQ/csd.py#L57 Maybe we should check that the |
arokem
reviewed
Jul 24, 2020
richford
force-pushed
the
bvals-preallocation
branch
from
2f9864d
to
4a5c32e
Compare
|
Rebased on master. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #56.
prepare_datareturns the last Nifti1Image generated fromdata_filesin order to replicate the pre-existing behavior. But was that intended? It seems that the old behavior was to return the Nifti1Image produced by runningnib.load()on the last element ofdata_files. Is there something special about the last one?