[ENH] Change default BundleDict behavior to resample #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arokem
reviewed
Oct 15, 2021
AFQ/api.py
Outdated
| @@ -92,7 +92,7 @@ class BundleDict(MutableMapping): | |||
| def __init__(self, | |||
| bundle_info=BUNDLES, | |||
| seg_algo="afq", | |||
| resample_to=False): | |||
| resample_to=afd.read_mni_template()): | |||
There was a problem hiding this comment.
This worries me a little bit. Having a function call in the signature of another function seems a bit risky. Doesn't this trigger the mni download on import? How about setting this to None and then have the default behavior be as follows?
if resample_to is None:
resample_to = afd.read_mni_template()
There was a problem hiding this comment.
Or is that too confusing? Because None sounds like you are not resampling?
There was a problem hiding this comment.
I don't think this triggers download on import, but I agree that making this None would be more in line with what we do elsewhere. I will make that change.
|
LGTM! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users who specify a custom bundledict usually still want to resample, and might miss the
resample_toparameter.