Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Consent Picker #523

Merged
merged 58 commits into from
Jun 5, 2024
Merged

WIP: Consent Picker #523

merged 58 commits into from
Jun 5, 2024

Conversation

Emily-ejag
Copy link
Contributor

@Emily-ejag Emily-ejag commented Apr 29, 2024

Proposed changes

A new component which will be integrated into the create/edit administrations to manage consent and assent forms for participants. This new component includes the following features:

  • Form Selection:

    • Help me choose: Based on the data collection criteria, the system can automatically select the appropriate form.
    • I know what I want: Users can manually choose the specific form they want to use.
  • Sign-In Process:

    • When participants sign in, the system will check for any new consent or assent forms associated with their administration.
    • If new forms are required, participants will be prompted to sign them.
    • If the forms have not changed from the previous administration, they will not be prompted again.
  • Age-Based Form Assignment:

    • Participants aged 7-17 will receive an assent form.
    • Participants under 7 will not receive any forms.
    • Participants 18 or over will receive a consent form.

These changes aim to streamline the process of obtaining consent and assent from participants, ensuring compliance and ease of use.

Types of changes

What types of changes does this pull request introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

Further comments

Copy link

github-actions bot commented Apr 29, 2024

Visit the preview URL for this PR (updated for commit 2cbfbd5):

https://roar-staging--pr523-enh-consent-picker-bgvkrxzz.web.app

(expires Wed, 12 Jun 2024 05:12:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

Copy link

cypress bot commented Apr 29, 2024

Passing run #2327 ↗︎

0 26 0 0 Flakiness 0

Details:

Tests for PR 523 "WIP: Consent Picker" from commit "2cbfbd5adf6a2fdbdf09353b0173...
Project: roar-dashboard-e2e Commit: 2cbfbd5adf
Status: Passed Duration: 03:51 💡
Started: Jun 5, 2024 5:12 AM Ended: Jun 5, 2024 5:16 AM

Review all test suite changes for PR #523 ↗︎

@Emily-ejag Emily-ejag self-assigned this May 13, 2024
@Emily-ejag Emily-ejag requested a review from Zio-4 May 30, 2024 22:32
src/components/CardAdministration.vue Outdated Show resolved Hide resolved
@Emily-ejag Emily-ejag requested a review from Zio-4 May 31, 2024 17:27
@Zio-4
Copy link
Contributor

Zio-4 commented May 31, 2024

Also before merging, I think it would be helpful to squash commits and make the commit message more descriptive since there are a lot.

src/assets/styles/theme-tailwind.css Outdated Show resolved Hide resolved
src/components/ConsentPicker.vue Outdated Show resolved Hide resolved
src/components/ConsentPicker.vue Show resolved Hide resolved
src/components/ConsentPicker.vue Show resolved Hide resolved
src/components/ConsentPicker.vue Outdated Show resolved Hide resolved
src/components/ConsentPicker.vue Show resolved Hide resolved
src/components/ConsentPicker.vue Show resolved Hide resolved
src/components/ConsentPicker.vue Outdated Show resolved Hide resolved
src/components/ConsentPicker.vue Show resolved Hide resolved
src/components/ConsentPicker.vue Show resolved Hide resolved
@Emily-ejag Emily-ejag merged commit f52dc25 into main Jun 5, 2024
15 of 16 checks passed
@Emily-ejag Emily-ejag deleted the enh/consent-picker branch June 5, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants