Fix Cypress Test Concurrency #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit e625fb9): https://roar-staging--pr570-fix-test-concurrency-ilzgpeaf.web.app (expires Thu, 23 May 2024 16:40:11 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460 |
Passing run #1784 ↗︎
Details:
Review all test suite changes for PR #570 ↗︎ |
|||||||||||||||
richford
requested changes
May 14, 2024
package.json
Outdated
There was a problem hiding this comment.
Thanks for the clarification that this is just to trigger/test the tests. Please change back when appropriate.
package.json
Outdated
There was a problem hiding this comment.
Thanks for the clarification that this is just to trigger/test the tests. Please revert when appropriate
ksmontville
force-pushed
the
fix/test-concurrency
branch
2 times, most recently
from
8827ba9
to
e4e0282
Compare
…compare to feature branch package json
… for test workflows.
ksmontville
force-pushed
the
fix/test-concurrency
branch
from
e4e0282
to
e625fb9
Compare
richford
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix an issue with Cypress tests concurrently modifying the same document, resulting in failed tests. It introduces a check to see if the app/game npm package has changed within a new PR; if so, it runs the tests for that game. This PR also splits the Cypress test suite into multiple GitHub workflows: participant, partner, super admin.