Use mac's md5 if md5sum is not available #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes yeban#4 - Also fixes a loop (where it kept on downloading and then deleting, and then downloading... ) if md5sum was not available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across a never-ending loop - where it deleted the tared file (because of md5sum not being available) and kept on redownloading the file.
As such, put together this quick fix.
It now supports mac's
md5(#4) - and gets around the issue thatmd5does not have-c.Can you also please release a new gem to rubygems as GeneValidator uses the gem. (The last few commits are not included in the currently released gem)