Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme is applied to JupyterLab's UI even when it is not the selected theme #18

Closed
norweeg opened this issue Jul 28, 2021 · 5 comments · Fixed by #24
Closed

Theme is applied to JupyterLab's UI even when it is not the selected theme #18

norweeg opened this issue Jul 28, 2021 · 5 comments · Fixed by #24

Comments

@norweeg
Copy link

norweeg commented Jul 28, 2021

I have a different theme selected at the moment, however jupyterlab_neon_theme is still styling UI elements

image

image
Python 3.9.6
Node v16.5.0

@yeebc
Copy link
Owner

yeebc commented Jul 29, 2021 via email

@norweeg
Copy link
Author

norweeg commented Jul 29, 2021

I don't remember. I installed it some time ago and did not uninstall it. I recently updated my JupyterLab, so as a matter of habit, I also ran jupyter labextension update --all and jupyter lab build afterwards

@miwojc
Copy link

miwojc commented Oct 22, 2021

i have the same issue. installed with this command:

jupyter labextension install @yeebc/jupyterlab_neon_theme

JupyterLab version 3.1.7

Additionally JupyterLab Vim extension stopped working. I uninstalled the Neon theme and after that JupyterLab Vim is back. Uinstalled it with:

jupyter labextension uninstall @yeebc/jupyterlab_neon_theme

@dd-ugm
Copy link

dd-ugm commented Apr 17, 2022

Same issue here. I installed via JupyterLab extension manager and jupyter lab build.

Edit: Miami Nights fork has a similar issue.

@vidartf
Copy link
Contributor

vidartf commented Jun 28, 2022

See the updated docs here: https://jupyterlab.readthedocs.io/en/stable/extension/extension_dev.html#theme-plugins

Theme CSS assets are specially bundled in an extension (see Theme path) so they can be unloaded or loaded as the theme is activated. Since CSS files referenced by the style or styleModule keys are automatically bundled and loaded on the page, the theme files should not be referenced by these keys.

I think the fix is to remove the "style" key from package.json.

@vidartf vidartf mentioned this issue Aug 25, 2022
@yeebc yeebc closed this as completed in #24 Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants