fix error return but uncheck and fix bug #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chm
reviewed
May 7, 2019
| @@ -22,7 +22,7 @@ package main | |||
|
|
|||
| import ( | |||
| "fmt" | |||
|
|
|||
| "errors" | |||
There was a problem hiding this comment.
system packages should be grouped in first block
Chm
reviewed
May 7, 2019
Chm
reviewed
May 8, 2019
cmd/gyee/configcmd.go
Outdated
| Name: "config", | ||
| Usage: "Manage config", | ||
| Category: "CONFIG COMMANDS", | ||
| Description: ` |
There was a problem hiding this comment.
leading newline here was shown in help text, no need to format
added 2 commits
May 8, 2019 13:19
|
I see u've got 7 commits with empty and merge along the way. |
|
master branch is protected by default, you may find a dedicated patch branch handy. |
|
OK |
|
you can close this pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修改saveConfig 函数返回值，由nil修改为具体的错误类型
修复SaveConfigToFile遇到错误应该直接返回error，而不是继续执行下面的代码