createfeature on feature definition doesn't write out any data?

[cchderrick]

I was following the test/test_gdal_tutorials.jl script, the tutorial lead to shapefiles without any data.

AG.create("$pointshapefile.shp", "ESRI Shapefile") do dataset
            ...
            featuredefn = AG.getlayerdefn(layer)
            @test AG.getname(featuredefn) == "point_out"
            AG.createfeature(featuredefn) do feature # This doesn't write any data out
            #AG.createfeature(layer) do feature # I ended with this, which works
                AG.setfield!(feature, AG.getfieldindex(feature, "Name"), "myname")
            ...
end

It doesn't error out because it is defined in context.jl line 52. So I am not sure if this is a bug or user error.

References:

ArchGDAL.jl/src/context.jl

Lines 52 to 61 in 0dbf3f7

	function createfeature(f::Function, featuredefn::FeatureDefn)
	feature = unsafe_createfeature(featuredefn); reference(featuredefn)
	# the additional reference & dereference here is to deal with the case
	# where you start by (1) creating a featuredefn (0 references)
	# before (2) using it to create a feature here.
	# if we do not artificially increase the reference, then destroy(feature)
	# will release the featuredefn, when we're going to handle it ourselves
	# later. Therefore we dereference (rather than release) the featuredefn.
	try f(feature) finally destroy(feature); dereference(featuredefn) end
	end

ArchGDAL.jl/test/test_gdal_tutorials.jl

Lines 110 to 116 in 0dbf3f7

	featuredefn = AG.getlayerdefn(layer)
	@test AG.getname(featuredefn) == "point_out"
	AG.createfeature(featuredefn) do feature
	AG.setfield!(feature, AG.getfieldindex(feature, "Name"), "myname")
	AG.setgeomdirectly!(feature, AG.unsafe_createpoint(100.123, 0.123))
	end
	end

[visr]

Yeah I believe it should be called on layers. See also JuliaGeo/GDAL.jl#59. We should probably add the feature count test here as well.

[yeesian]

1. yeah it should have been called on the layer in that test. Hence the bug label
2. More generally, I can see how it will be confusing to users, and we should add documentation to distinguish between creating "floating" features, versus features that are "owned" by layers.

[yeesian]

Test bug has been fixed in #67