-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ERC-20 Support #69
Comments
Here's my first pass. Launch Form
Yeet Details
Yeet Form
|
Having us provide the token address is complicated and kinda makes us the gatekeepers of what tokens can be used. If it is easier for this version I understand but it is not ideal. We will have to manage different token addresses on different networks. And then we will be responsible for making updates to the code when support for new tokens is added. It would be better to inform the user what they are signing up for. And then verify the address they added is the token they expected.
There is nothing in this view informing the user what they are spending. It was on the previous view but would be a good idea to have it here so they know the type of tokens they are contributing/approving. |
|
@TravisWyche We are prepared for any valid ERC20. And it should be the same on all chains. |
Second pass: Launch Form
Yeet Form
|
@TravisWyche this works for me! Thanks., |
spec notes ContractsImplement ERC20 Yeeter contract
SubgraphUpdate for ERC20 Shaman
DappGeneral
Hooks
Utils
address payable _token,
uint256 _startTime,
uint256 _endTime,
bool _isShares,
uint256 _minTribute,
uint256 _multiplier,
uint256 _goal,
address[] memory _feeRecipients,
uint256[] memory _feeAmounts UI
|
"bigger because a new contract plus it touches everything in the app"
Requires a token approval before yeeting.
we are working with un-audited contracts - and this adds another. we might need to note that in the UI/faq/docs or something
DESIGN UPDATES
Launch form
Yeet details
Yeet form
The text was updated successfully, but these errors were encountered: