Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a favicon #49

Closed
j-rewerts opened this issue Jan 22, 2019 · 7 comments
Closed

Add a favicon #49

j-rewerts opened this issue Jan 22, 2019 · 7 comments
Assignees
@CodyGramlich
Labels
enhancement New feature or request

Comments

@j-rewerts
Copy link
Member

No description provided.

@j-rewerts j-rewerts added the enhancement New feature or request label Jan 22, 2019
@j-rewerts
Copy link
Member Author

We're using Angular's project icon currently. @CodyGramlich Could you post the favicon you're thinking about using in here?

@CodyGramlich
Copy link
Collaborator

Unable to post .ico files here.

@j-rewerts
Copy link
Member Author

I'd like the ico to have a few features:

  • Slight margin around the outside
  • Transparent background
  • The letters YCB

@CodyGramlich
Copy link
Collaborator

I made the magnifying glass one have a transparent background and made one with the letters YCB which look like

favicon_magnify_ss

and

favicon_ycb_ss

I'm not sure what you mean by slight margin. Let me know what you think of these and if I should make some changes to the one with the YCB letters.

@slmyers
Copy link
Member

slmyers commented Jan 23, 2019

I like the second one.

@j-rewerts
Copy link
Member Author

Submit a PR when you get a chance!

@CodyGramlich
Copy link
Collaborator

Closed with #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CodyGramlich CodyGramlich

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@slmyers @j-rewerts @CodyGramlich