Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snapshot testing #74

Closed
j-rewerts opened this issue Feb 6, 2019 · 2 comments
Closed

Fix snapshot testing #74

j-rewerts opened this issue Feb 6, 2019 · 2 comments

Comments

@j-rewerts
Copy link
Member

We currently have problems with reproducibility. Our snapshots often change:

      Object {
        "guid": "hp5mupqcVY8ZMiKg7Q91Uoi4Wf",
        "queryIDs": Array [
    -     "C8NZoL1Nf7VEgEC4VMFI9GlebN",
          "d5NswIlUvzxY0AJ1hGm4eKQtS4",
    +     "fMwdx1jiAZUt09ALDer98GardT",
          "JeXk8cOZnqJMepmHpxDqpsEXNE",
          "jI1HlTlpbULsSVUmHnYi3ZlVJ7",
          "jzMQkEK41gnhmwWyxAuWF3eZ4d",
          "NOyR66aE30dJYXgdHJ2CvGLpnx",
          "qZyokzKnpIw3Ue6mdTi8je3knK",

We need our snapshots to be the exact same between runs.

@CodyGramlich
Copy link
Collaborator

This seems to be only a problem with GET /protected/program/:guid. It only returns 10 queries when there are 11 queries for this program. The search size for elasticsearch wasn't set on EsQuery.service.ts getByGuid(), so I changed it to a size of 10000. Also, I don't think this endpoint is ever used in the application currently.

@j-rewerts j-rewerts mentioned this issue Feb 21, 2019
@j-rewerts
Copy link
Member Author

Fixed by @CodyGramlich with #87.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants