fix: Minor ditherImage update

yegor-pelykh · May 12, 2024 · 3278068 · 3278068
1 parent 90578df
commit 3278068
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/src/filter/filter.ts b/src/filter/filter.ts
@@ -1107,19 +1107,16 @@ export abstract class Filter {
     });
 
     const imageCopy = opt.image.clone();
-
-    const pIter = opt.image[Symbol.iterator]();
-    let itRes = pIter.next();
     for (let y = 0; y < height; y++) {
       if (serpentine) {
         direction *= -1;
       }
 
       const x0 = direction === 1 ? 0 : width - 1;
       const x1 = direction === 1 ? width : 0;
-      for (let x = x0; x !== x1; x += direction, itRes = pIter.next()) {
+      for (let x = x0; x !== x1; x += direction) {
         // Get original color
-        const pc = itRes.value;
+        const pc = imageCopy.getPixel(x, y);
         const r1 = Math.trunc(pc.getChannel(0));
         const g1 = Math.trunc(pc.getChannel(1));
         const b1 = Math.trunc(pc.getChannel(2));

diff --git a/test/filter/filter.quantize.test.ts b/test/filter/filter.quantize.test.ts
@@ -83,8 +83,10 @@ describe('Filter', () => {
       data: input,
     })!;
     const q1_ = Filter.quantize({
-      image: i1_,
-      numberOfColors: 32,
+      image: Filter.grayscale({
+        image: i1_,
+      }),
+      numberOfColors: 2,
       dither: DitherKernel.floydSteinberg,
     });
     output = encodePng({