Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HtBody.java:39-44: The implementation of method stream()... #3

Closed
0pdd opened this issue Apr 4, 2018 · 23 comments
Closed

HtBody.java:39-44: The implementation of method stream()... #3

0pdd opened this issue Apr 4, 2018 · 23 comments
Labels
bug Something isn't working

Comments

@0pdd
Copy link
Collaborator

0pdd commented Apr 4, 2018

The puzzle 1-94e51014 from #1 has to be resolved:

* @todo #1:30min The implementation of method stream() is less than
* effective, because it reads the entire content of the response, turning
* it into text and then splitting. What if the content is binary and
* can't be converted to string? What if the content is super big
* and must be presented as an stream, not a piece of text. Let's fix
* it.

The puzzle was created by Yegor Bugayenko on 04-Apr-18.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

0pdd referenced this issue Apr 4, 2018
@0pdd 0pdd mentioned this issue Apr 4, 2018
@0crat
Copy link
Collaborator

0crat commented Apr 4, 2018

@0pdd/z I'm not managing this repo, remove the webhook or contact me in Slack, as explained in §11; I'm not managing yegor256/cactoos-http GitHub repository, you have to contact me in Slack first, see §11 /cc @yegor256/z

@yegor256 yegor256 added the bug Something isn't working label Apr 4, 2018
@0crat 0crat added the scope label Apr 4, 2018
@0crat
Copy link
Collaborator

0crat commented Apr 4, 2018

Job #3 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Apr 4, 2018

The job #3 assigned to @flslkxtc/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this

@0crat
Copy link
Collaborator

0crat commented Apr 9, 2018

@flslkxtc/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@0crat
Copy link
Collaborator

0crat commented Apr 14, 2018

The user @flslkxtc/z resigned from #3, please stop working. Reason for job resignation: It is older than 10 days, see §8

@0crat
Copy link
Collaborator

0crat commented Apr 14, 2018

Resigned on delay, see §8: -30 point(s) just awarded to @flslkxtc/z

@0crat
Copy link
Collaborator

0crat commented Apr 14, 2018

The job #3 assigned to @victornoel/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this

@victornoel
Copy link
Contributor

victornoel commented Apr 14, 2018

Reminder to myself: check #24 and #4 which have the same problem, and this SO answer that discusses the format of header/body/etc

@0crat
Copy link
Collaborator

0crat commented Apr 19, 2018

@victornoel/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@victornoel
Copy link
Contributor

@0crat waiting for #29

@yegor256 it's clearly an ARC job to redefine responsibilities of object, so I will need you to ensure this is going the right way, I don't see any sane way to implement HtBody, HtStatus and HtHead separately without lots of duplication, I would prefer to base the three of them on something that is more aware of the peculiarities of an http message.

@0crat
Copy link
Collaborator

0crat commented Apr 20, 2018

@0crat waiting for #29 @yegor256 it's clearly an ARC job to redefine responsibilities of obje... (here)

@victornoel The impediment for #3 was registered successfully by @victornoel/z

@victornoel
Copy link
Contributor

@llorllale sorry, you are the ARC now, see the comment above.

@llorllale
Copy link
Collaborator

@victornoel see my comment in #29

victornoel added a commit to victornoel/cactoos-http that referenced this issue Apr 21, 2018
@victornoel
Copy link
Contributor

@0crat waiting for review of #32

@0crat
Copy link
Collaborator

0crat commented Apr 21, 2018

@0crat waiting for review of #32 (here)

@victornoel Job #3 is already on hold

victornoel added a commit to victornoel/cactoos-http that referenced this issue Apr 29, 2018
victornoel added a commit to victornoel/cactoos-http that referenced this issue Apr 29, 2018
victornoel added a commit to victornoel/cactoos-http that referenced this issue Apr 30, 2018
@0pdd 0pdd closed this as completed Apr 30, 2018
@0pdd
Copy link
Collaborator Author

0pdd commented Apr 30, 2018

The puzzle 1-94e51014 has disappeared from the source code, that's why I closed this issue.

@0pdd
Copy link
Collaborator Author

0pdd commented Apr 30, 2018

@0pdd the puzzle #37 is still not solved.

@0crat
Copy link
Collaborator

0crat commented Apr 30, 2018

@elenavolokhova/z please review this job completed by @victornoel/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label Apr 30, 2018
@0crat
Copy link
Collaborator

0crat commented Apr 30, 2018

The job #3 is now out of scope

@elenavolokhova
Copy link

@0crat quality good

@0crat
Copy link
Collaborator

0crat commented Apr 30, 2018

Order was finished, quality is "good": +35 point(s) just awarded to @victornoel/z

@0crat
Copy link
Collaborator

0crat commented Apr 30, 2018

Quality review completed: +8 point(s) just awarded to @elenavolokhova/z

@0pdd
Copy link
Collaborator Author

0pdd commented May 17, 2018

@0pdd the only puzzle #37 is solved here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants