Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#72) Update cactoos to 0.39 #73

Merged
merged 1 commit into from
Feb 20, 2019

Conversation

victornoel
Copy link
Contributor

#72 Update cactoos to 0.39

@victornoel victornoel mentioned this pull request Feb 2, 2019
@0crat 0crat added the scope label Feb 2, 2019
@0crat
Copy link
Collaborator

0crat commented Feb 2, 2019

Job #73 is now in scope, role is REV

@0crat
Copy link
Collaborator

0crat commented Feb 2, 2019

This pull request #73 is assigned to @fabriciofx/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

@codecov-io
Copy link

codecov-io commented Feb 3, 2019

Codecov Report

Merging #73 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #73      +/-   ##
===========================================
- Coverage     96.93%   96.9%   -0.04%     
  Complexity       67      67              
===========================================
  Files            17      17              
  Lines           196     194       -2     
  Branches         15      15              
===========================================
- Hits            190     188       -2     
  Misses            4       4              
  Partials          2       2
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/cactoos/http/HtBody.java 100% <ø> (ø) 2 <0> (ø) ⬇️
...main/java/org/cactoos/http/HtResponseEnvelope.java 100% <ø> (ø) 2 <0> (ø) ⬇️
src/main/java/org/cactoos/http/HtSecureWire.java 100% <ø> (ø) 6 <0> (ø) ⬇️
src/main/java/org/cactoos/http/HtHead.java 100% <ø> (ø) 9 <0> (ø) ⬇️
src/main/java/org/cactoos/http/HtWire.java 93.1% <ø> (ø) 9 <0> (ø) ⬇️
src/main/java/org/cactoos/http/HtUpgradeWire.java 100% <ø> (ø) 2 <0> (ø) ⬇️
src/main/java/org/cactoos/http/HtCookies.java 100% <ø> (ø) 4 <0> (ø) ⬇️
src/main/java/org/cactoos/http/io/SkipInput.java 100% <ø> (ø) 5 <0> (ø) ⬇️
src/main/java/org/cactoos/http/HtTimedWire.java 100% <100%> (ø) 2 <1> (ø) ⬇️
src/main/java/org/cactoos/http/HtAutoRedirect.java 91.66% <100%> (-1.2%) 4 <0> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1248e0c...9f10348. Read the comment docs.

@victornoel
Copy link
Contributor Author

@fabriciofx ping

@victornoel
Copy link
Contributor Author

@llorllale REV seems not to be around here anymore... anyway to get a review for this? It is blocking other PRs.

@llorllale
Copy link
Collaborator

@0crat refuse

@llorllale
Copy link
Collaborator

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Feb 20, 2019

@rultor merge

@llorllale OK, I'll try to merge now. You can check the progress of the merge here

@0crat
Copy link
Collaborator

0crat commented Feb 20, 2019

@0crat refuse (here)

@llorllale The user @fabriciofx/z resigned from #73, please stop working. Reason for job resignation: Order was cancelled

@0crat
Copy link
Collaborator

0crat commented Feb 20, 2019

This pull request #73 is assigned to @iprogrammerr/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

@rultor rultor merged commit 9f10348 into yegor256:master Feb 20, 2019
@rultor
Copy link
Collaborator

rultor commented Feb 20, 2019

@rultor merge

@llorllale Done! FYI, the full log is here (took me 18min)

@0crat 0crat removed the scope label Feb 20, 2019
@0crat
Copy link
Collaborator

0crat commented Feb 20, 2019

Quality is low, no payment, see §31:

@0crat
Copy link
Collaborator

0crat commented Feb 20, 2019

Job was finished in 0 hours, bonus for fast delivery is possible (see §36)

@0crat
Copy link
Collaborator

0crat commented Feb 20, 2019

The job #73 is now out of scope

@0crat
Copy link
Collaborator

0crat commented Feb 20, 2019

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @llorllale/z

@victornoel victornoel deleted the 72-upgrade-cactoos branch February 20, 2019 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants