#1549: Add ctor to map.Merged #1550
Conversation
| new Merged<>( | ||
| new MapOf<>( | ||
| new MapEntry<>("a", 1) | ||
| ), | ||
| new MapOf<>( | ||
| new MapEntry<>("b", 2) | ||
| ) | ||
| ), |
There was a problem hiding this comment.
@andreoss I think you wanted to test Merged with Iterable constructor :) It should be like this :
new Merged<>(
new IterableOf<>(
new MapOf<>(
new MapEntry<>("a", 1)
),
new MapOf<>(
new MapEntry<>("b", 2)
)
)
)There was a problem hiding this comment.
@baudoliver7 Actually not, there's not need to test Iterable ctor because it is primary and getting hit anyway.
There was a problem hiding this comment.
@andreoss That's right ! But it's because of the test name (behavesAsMapCreatedFromIterable) that I said that. However, you change it in your last commit.
| @Test | ||
| public void behavesAsMapCreatedFromIterable() { | ||
| new Assertion<>( | ||
| "Must behave as a map", |
There was a problem hiding this comment.
@andreoss I suggest this message : Must behave as a map when created from iterable
|
|
||
| /** | ||
| * Ctor. | ||
| * @param maps Maps to merge. |
There was a problem hiding this comment.
@andreoss I suggest to write as description : Iterable of {@link Map}s to merge
There was a problem hiding this comment.
@baudoliver7 Fixed.
Codecov Report
@@ Coverage Diff @@
## master #1550 +/- ##
============================================
- Coverage 90.85% 90.82% -0.03%
- Complexity 1567 1570 +3
============================================
Files 291 291
Lines 3694 3693 -1
Branches 121 121
============================================
- Hits 3356 3354 -2
Misses 308 308
- Partials 30 31 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
@andreoss Thanks. @victornoel It looks good to me. Please, check/merge
|
By the way @andreoss, no need to create a ticket if you plan to create a PR directly :) |
|
@rultor merge |
@victornoel OK, I'll try to merge now. You can check the progress of the merge here |
@victornoel Done! FYI, the full log is here (took me 10min) |
|
@sereshqua/z please review this job completed by @baudoliver7/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
|
@0crat quality good |
Per #1549