polish

yegor256 · Apr 27, 2024 · be8be31 · be8be31
1 parent 10d71ab
commit be8be31
Show file tree

Hide file tree

Showing 3 changed files with 39 additions and 34 deletions.
diff --git a/installs/install-gradle.sh b/installs/install-gradle.sh
@@ -32,18 +32,20 @@ fi
 
 if gradle --version >/dev/null 2>&1; then
   gradle --version
-else
-  if [ ! -e /usr/local ]; then
-    echo "The directory /usr/local must exist"
-    exit 1
-  fi
-  gradle_version=7.4
-  cd /usr/local
-  wget --quiet https://services.gradle.org/distributions/gradle-${gradle_version}-bin.zip
-  unzip -qq gradle-${gradle_version}-bin.zip
-  rm gradle-${gradle_version}-bin.zip
-  mv gradle-${gradle_version} gradle
-  ln -s /usr/local/gradle/bin/gradle /usr/local/bin/gradle
-  echo "Gradle installed into /usr/local/gradle"
-  gradle --version
+  echo "Gradle is already installed"
+fi
+
+if [ ! -e /usr/local ]; then
+  echo "The directory /usr/local must exist"
+  exit 1
 fi
+
+gradle_version=7.4
+cd /usr/local
+wget --quiet https://services.gradle.org/distributions/gradle-${gradle_version}-bin.zip
+unzip -qq gradle-${gradle_version}-bin.zip
+rm gradle-${gradle_version}-bin.zip
+mv gradle-${gradle_version} gradle
+ln -s /usr/local/gradle/bin/gradle /usr/local/bin/gradle
+echo "Gradle installed into /usr/local/gradle"
+gradle --version
diff --git a/installs/install-jpeek.sh b/installs/install-jpeek.sh
@@ -28,11 +28,12 @@ set -o pipefail
 
 if [ -e "${JPEEK}" ]; then
   echo "jPeek JAR is already here: ${JPEEK}"
-else
-  jpeek_version=0.32.0
-  cd /tmp
-  wget --quiet https://repo1.maven.org/maven2/org/jpeek/jpeek/${jpeek_version}/jpeek-${jpeek_version}-jar-with-dependencies.jar
-  mkdir -p "$(dirname "${JPEEK}")"
-  mv "jpeek-${jpeek_version}-jar-with-dependencies.jar" "${JPEEK}"
-  echo "jPeek downloaded into ${JPEEK}"
+  exit
 fi
+
+jpeek_version=0.32.0
+cd /tmp
+wget --quiet https://repo1.maven.org/maven2/org/jpeek/jpeek/${jpeek_version}/jpeek-${jpeek_version}-jar-with-dependencies.jar
+mkdir -p "$(dirname "${JPEEK}")"
+mv "jpeek-${jpeek_version}-jar-with-dependencies.jar" "${JPEEK}"
+echo "jPeek downloaded into ${JPEEK}"
diff --git a/installs/install-pmd.sh b/installs/install-pmd.sh
@@ -32,17 +32,19 @@ fi
 
 if pmd pmd --version >/dev/null 2>&1; then
   pmd pmd --version
-else
-  if [ ! -e /usr/local ]; then
-    echo "The directory /usr/local must exist"
-    exit 1
-  fi
-  pmd_version=6.55.0
-  cd /usr/local
-  wget --quiet https://github.com/pmd/pmd/releases/download/pmd_releases%2F6.55.0/pmd-bin-${pmd_version}.zip
-  unzip -qq pmd-bin-${pmd_version}.zip
-  rm pmd-bin-${pmd_version}.zip
-  mv pmd-bin-${pmd_version} pmd
-  ln -s /usr/local/pmd/bin/run.sh /usr/local/bin/pmd
-  echo "PMD installed into /usr/local/bin/pmd"
+  echo "PMD is already installed"
 fi
+
+if [ ! -e /usr/local ]; then
+  echo "The directory /usr/local must exist"
+  exit 1
+fi
+
+pmd_version=6.55.0
+cd /usr/local
+wget --quiet https://github.com/pmd/pmd/releases/download/pmd_releases%2F6.55.0/pmd-bin-${pmd_version}.zip
+unzip -qq pmd-bin-${pmd_version}.zip
+rm pmd-bin-${pmd_version}.zip
+mv pmd-bin-${pmd_version} pmd
+ln -s /usr/local/pmd/bin/run.sh /usr/local/bin/pmd
+echo "PMD installed into /usr/local/bin/pmd"