Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to me that the unit tests for the metrics were written incorrectly. When writing
grep "smth"
the utility looks for occurrences of exactly "smth", so if, for example, the metric returns 0.5, thengrep "0"
will consider that this is correct. This situation happened with ahf and sahf. This is not critical, it seems that all the metrics are working correctly, but it is better that the tests are correct.