Relative File Volatility by Commits (RFVC) #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yegor256 Please, check this PR |
|
@IlnurHA looks very good! please, run |
|
@yegor256 It seems that all checks are passed in |
yegor256
reviewed
May 3, 2024
|
|
||
| printf "class Foo {}" > "${java3}" | ||
| git add "${java3}" | ||
| git commit --quiet -m "-third commit" |
There was a problem hiding this comment.
@IlnurHA try to make a few additional commits here and check the result of the metric, just to make sure it gives correct values
|
@yegor256 I added more commits as requested and more checks just to be sure that everything is correctly calculated. Can you check please? |
|
@IlnurHA thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding new metric (RFVC) (Issue #128). In the issue you mentioned Relative File Volatility by Hits, but I think it would be better to create separate issue to implement this metric