Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NOMR metric to ast.py #317

Merged
merged 8 commits into from
May 19, 2024
Merged

Added NOMR metric to ast.py #317

merged 8 commits into from
May 19, 2024

Conversation

zaqbez39me
Copy link
Contributor

@zaqbez39me zaqbez39me commented May 18, 2024

Added new metric - count of number methods with @Override divided by total number of methods. Here it is namedNumber of Overriding Methods Ratio (NOMR)

Blocked by #316
Closes #192

@zaqbez39me
Copy link
Contributor Author

zaqbez39me commented May 18, 2024

@yegor256 please, check this out after #316

@yegor256
Copy link
Owner

@zaqbez39me what about a unit test? how do we know that this code works as expected?

@zaqbez39me
Copy link
Contributor Author

@yegor256 tests are implemented in #316

@yegor256
Copy link
Owner

@zaqbez39me I think, you should also remove the shellcheck disable=SC2317 line

@zaqbez39me
Copy link
Contributor Author

@yegor256 oops, sorry, forgot to add this change to staged

@zaqbez39me
Copy link
Contributor Author

@yegor256 check it. Fixed all the issues and enabled tests

@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented May 19, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 428b12f into yegor256:master May 19, 2024
9 checks passed
@rultor
Copy link
Collaborator

rultor commented May 19, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 20min)

@yegor256
Copy link
Owner

@zaqbez39me thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New metric - count of number methods with @Override divided by total number of methods
3 participants