Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change for pip3 #330

Merged
merged 1 commit into from
May 21, 2024
Merged

Change for pip3 #330

merged 1 commit into from
May 21, 2024

Conversation

timur-harin
Copy link
Contributor

@yegor256

While installing python3 - we need to use pip3, not pip

So I suggest changing check to pip3 while install-pip.sh

@timur-harin timur-harin mentioned this pull request May 19, 2024
@@ -25,7 +25,7 @@ set -e
set -o pipefail

"${LOCAL}/help/assert-tool.sh" python3 --version
"${LOCAL}/help/assert-tool.sh" pip --version
"${LOCAL}/help/assert-tool.sh" pip3 --version

"${LOCAL}/help/sudo.sh" python3 -m pip install --upgrade pip
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timur-harin but here it's pip instead of pip3? What is right?

Copy link
Contributor Author

@timur-harin timur-harin May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yegor256
Yes, because inside python3 only pip exists

timur ~  pip --version 
zsh: command not found: pip
timur  ~  pip3 --version
pip 24.0 from /Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/pip (python 3.11)
timur  ~  python3 -m pip --version
pip 24.0 from /Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/pip (python 3.11)
timur  ~  python3 -m pip3 --version
/usr/local/bin/python3: No module named pip3

@timur-harin
Copy link
Contributor Author

@yegor256
Please check it

@yegor256 yegor256 merged commit 595af54 into yegor256:master May 21, 2024
9 checks passed
@yegor256
Copy link
Owner

@timur-harin thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants