Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#228): files in steps/clone.sh for percentile filter #352

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

h1alexbel
Copy link
Contributor

@h1alexbel h1alexbel commented Jul 1, 2024

@yegor256 take a look, please

In this pull request, I've introduced method files_in_repo for aggregating a number of files in the repository, as required to filter out repositories by number of files using percentiles.

ref #228

@h1alexbel h1alexbel changed the title feat(#228): repo_in_files for percentile filter feat(#228): repo_in_files for percentile filter Jul 1, 2024
@yegor256
Copy link
Owner

yegor256 commented Jul 2, 2024

@h1alexbel are you planning to count the files before cloning the repo?

@h1alexbel h1alexbel changed the title feat(#228): repo_in_files for percentile filter feat(#228): files_in_repo for percentile filter Jul 2, 2024
@h1alexbel
Copy link
Contributor Author

@yegor256 yes, I planned to count them in the discovery phase. However, files count after cloning repository will make it more reasonable and remove the bottleneck with GitHub API in discovery-repos.rb.

@h1alexbel h1alexbel changed the title feat(#228): files_in_repo for percentile filter feat(#228): files in steps/clone.sh for percentile filter Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants