Skip to content

Commit

Permalink
more
Browse files Browse the repository at this point in the history
  • Loading branch information
yegor256 committed Feb 22, 2024
1 parent 2fbfb44 commit 116638a
Show file tree
Hide file tree
Showing 8 changed files with 48 additions and 3 deletions.
32 changes: 29 additions & 3 deletions 03-making-changes/03-making-changes.tex
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,15 @@
{A correlation between \ul{change size} and \ul{review quality} is acknowledged by Google and developers are strongly encouraged to make small, incremental changes (with the exception of large deletions and automated refactoring).}
{sadowski2018modern}

\thought{Don't group changes}
\thought{Don't group your changes}

\qte
[Carolyn D. Egelman]
{carolyn-egelman}
{Google categorizes CRs into specific sizes, these sizes are indicated as part of the code review tool and in the notification to the reviewer of the code change... The general advice is to split change requests for easier and quicker reviews when possible.}
{Google categorizes CRs into specific sizes, these sizes are indicated as part of the code review tool and in the notification to the reviewer of the code change... The general advice is to \ul{split} change requests for \ul{easier} and \ul{quicker} reviews when possible.}
{egelman2020predicting}

\thought{Insist on code reviews and merges, politely}
\thought{Insist on code reviews and merges... politely}

\qte
[Marco Ortu]
Expand All @@ -72,6 +72,21 @@
{The larger the difference in \ul{personality traits} between the requester and the closer, the more \ul{positive effect} it has on pull request acceptance.}
{iyer2019effects}

\qte
[Denae Ford]
{denae-ford}
{We observe that both \ul{social} and \ul{technical} aspects are being taken into consideration when deciding upon pull request acceptance. Moreover, we observe that many \ul{more} social aspects are being considered during the experiment than \ul{reported} during the post-experiment survey.}
{ford2019beyond}

\pitch{
\begin{multicols}{2}
\includegraphics[width=.9\linewidth]{eyes.png}
\source{ford2019beyond}
\par\columnbreak\par
GitHub is increasing size of the avatar images and emphasizing a developer's ``personal brand'' by spotlighting features such as the contribution heat map. In the future, platform designers must be more mindful in balancing the power of signals that can amplify bias or harm against users, while still providing the mechanisms for users to freely evaluate the merits of potential code contributions.
\end{multicols}
}

\thought{Be a leader and a boss of a pull request --- be the one who cares}

\qte
Expand All @@ -82,6 +97,17 @@

\thought{Mostly explain ``why'' you make changes, not ``what'' you change}

\pitch{\includegraphics[width=.9\linewidth]{quality-of-prs.png}
\source{liu2019automatic}}

\pitch{
\begin{multicols}{2}
\includegraphics[width=.9\linewidth]{pr.png}
\par\columnbreak\par
\includegraphics[width=.9\linewidth]{pr-codex.png}
\end{multicols}
}

\thought{Be prepared for criticism about your style, not functionality}

\qte
Expand Down
Binary file added 03-making-changes/eyes.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added 03-making-changes/pr-codex.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added 03-making-changes/pr.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added 03-making-changes/quality-of-prs.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added faces/denae-ford.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
18 changes: 18 additions & 0 deletions main.bib
Original file line number Diff line number Diff line change
Expand Up @@ -442,4 +442,22 @@ @article{iyer2019effects
pages={2632--2643},
year={2019},
publisher={IEEE}
}

@inproceedings{ford2019beyond,
title={{Beyond the Code Itself: How Programmers \emph{Really} Look at Pull Requests}},
author={Ford, Denae and Behroozi, Mahnaz and Serebrenik, Alexander and Parnin, Chris},
booktitle={{Proceedings of the 41st International Conference on Software Engineering: Software Engineering in Society}},
pages={51--60},
year={2019},
organization={IEEE}
}

@inproceedings{liu2019automatic,
title={{Automatic Generation of Pull Request Descriptions}},
author={Liu, Zhongxin and Xia, Xin and Treude, Christoph and Lo, David and Li, Shanping},
booktitle={{Proceedings of the 34th International Conference on Automated Software Engineering}},
pages={176--188},
year={2019},
organization={IEEE}
}
1 change: 1 addition & 0 deletions osbp.sty
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@

\newcommand\pitch[1]{\plush{\begin{pptMiddle} #1 \end{pptMiddle}}}
\newcommand\qte[4][]{\pitch{\pptQuote[\scriptsize\scshape\color{gray}{#1}]{../faces/#2.jpg}{#3}{\color{gray}\rmfamily\scriptsize\bibentry{#4}}}}
\newcommand\source[1]{\par{\scriptsize Source: \bibentry{#1}\par}}
\newcounter{thght}
\newcommand\thought[2][]{
\addtocounter{thght}{1}
Expand Down

0 comments on commit 116638a

Please sign in to comment.