Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Garbage characters in a puzzle name with Thymeleaf parser-level comment #104

Closed
php-coder opened this issue Jun 21, 2018 · 22 comments
Closed
Labels

Comments

@php-coder
Copy link
Contributor

php-coder commented Jun 21, 2018

For the following comment:

<!--/* @todo #884 /collection/{slug}/estimation: optimize summing of prices */-->

@0pdd created the issue with a title /collection/{slug}/estimation: optimize summing of prices */-->.

I think that it has happened because pdd incorrectly parses Thymeleaf parser-level comments.

Expected result: puzzle shouldn't have */--> at the end.

@0crat
Copy link
Collaborator

0crat commented Jun 21, 2018

@yegor256/z please, pay attention to this issue

@php-coder php-coder changed the title Invald Garbage characters in a puzzle name with Thymeleaf parser-level comment Jun 21, 2018
@yegor256 yegor256 added the bug label Jun 24, 2018
@0crat 0crat added the scope label Jun 24, 2018
@0crat
Copy link
Collaborator

0crat commented Jun 24, 2018

Job #104 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Jun 24, 2018

Thanks for your contribution, @php-coder/z! If you would be a member of the project, you would now earn +15 reputation points, as explained in §29. You can join and apply to it, see §2.

@0crat
Copy link
Collaborator

0crat commented Jun 24, 2018

The job #104 assigned to @robsonataide/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

@0crat
Copy link
Collaborator

0crat commented Jul 6, 2018

The job #104 assigned to @a6cexz/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@0crat
Copy link
Collaborator

0crat commented Jul 11, 2018

@a6cexz/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@a6cexz
Copy link
Contributor

a6cexz commented Jul 11, 2018

@0crat wait #110

@0crat
Copy link
Collaborator

0crat commented Jul 11, 2018

@0crat wait #110 (here)

@a6cexz The impediment for #104 was registered successfully by @a6cexz/z

@rultor rultor closed this as completed in ac348ee Jul 12, 2018
@0crat
Copy link
Collaborator

0crat commented Jul 12, 2018

@rultor/z the issue is closed not by @php-coder/z (its creator); I won't close the order; please, re-open it and ask @php-coder/z to close it

@a6cexz
Copy link
Contributor

a6cexz commented Jul 12, 2018

@php-coder please close this issue, #110 pr with the fix was recently merged

@php-coder
Copy link
Contributor Author

@a6cexz I can't close it (there is no button for that).

@a6cexz
Copy link
Contributor

a6cexz commented Jul 12, 2018

@php-coder I think you need to re-open this issue and them close it

@php-coder
Copy link
Contributor Author

@a6cexz I can't reopen it either.

@a6cexz
Copy link
Contributor

a6cexz commented Jul 12, 2018

@yegor256 would you please reopen and close this ticket, as it seems only you can do it, would greatly appreciate your help with this.

@0crat
Copy link
Collaborator

0crat commented Jul 20, 2018

@a6cexz/z resigned from #104, since the job is not in scope anymore

@0crat
Copy link
Collaborator

0crat commented Jul 20, 2018

The job #104 is now out of scope

@yegor256
Copy link
Member

@rultor release, tag is 0.20.4

@rultor
Copy link
Collaborator

rultor commented Dec 25, 2018

@rultor release, tag is 0.20.4

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Dec 25, 2018

@rultor release, tag is 0.20.4

@php-coder @yegor256 Oops, I failed. You can see the full log here (spent 3min)

Fetching: xcop-0.6.gem
Fetching: xcop-0.6.gem ( 14%)
Fetching: xcop-0.6.gem ( 33%)
Fetching: xcop-0.6.gem ( 53%)
Fetching: xcop-0.6.gem ( 72%)
Fetching: xcop-0.6.gem ( 91%)
Fetching: xcop-0.6.gem (100%)
Fetching: xcop-0.6.gem (100%)
Successfully installed xcop-0.6
Parsing documentation for differ-0.1.2
Installing ri documentation for differ-0.1.2
Parsing documentation for xcop-0.6
Installing ri documentation for xcop-0.6
Done installing documentation for differ, xcop after 0 seconds
2 gems installed
+ env
rvm_bin_path=/usr/local/rvm/bin
GEM_HOME=/usr/local/rvm/gems/ruby-2.5.1
TERM=xterm
SHELL=/bin/bash
DERBY_HOME=/usr/lib/jvm/java-8-oracle/db
IRBRC=/usr/local/rvm/rubies/ruby-2.5.1/.irbrc
OLDPWD=/home/r
MY_RUBY_HOME=/usr/local/rvm/rubies/ruby-2.5.1
USER=r
_system_type=Linux
rvm_path=/usr/local/rvm
head=git@github.com:yegor256/pdd.git
rvm_prefix=/usr/local
PATH=/usr/local/rvm/gems/ruby-2.5.1/bin:/usr/local/rvm/gems/ruby-2.5.1@global/bin:/usr/local/rvm/rubies/ruby-2.5.1/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games:/usr/lib/jvm/java-8-oracle/bin:/usr/lib/jvm/java-8-oracle/db/bin:/usr/lib/jvm/java-8-oracle/jre/bin:/usr/local/rvm/bin
MAIL=/var/mail/r
tag=0.20.4
author=yegor256
PWD=/home/r/repo
JAVA_HOME=/usr/lib/jvm/java-8-oracle
_system_arch=x86_64
_system_version=16.04
rvm_version=1.29.4 (latest)
head_branch=master
HOME=/home/r
SHLVL=2
LOGNAME=r
J2SDKDIR=/usr/lib/jvm/java-8-oracle
GEM_PATH=/usr/local/rvm/gems/ruby-2.5.1:/usr/local/rvm/gems/ruby-2.5.1@global
J2REDIR=/usr/lib/jvm/java-8-oracle/jre
RUBY_VERSION=ruby-2.5.1
_system_name=Ubuntu
_=/usr/bin/env
+ bundle install
Fetching gem metadata from https://rubygems.org/...........
Fetching gem metadata from https://rubygems.org/.
Resolving dependencies...
\u001b[32mFetching rake 12.0.0\u001b[0m
\u001b[32mInstalling rake 12.0.0\u001b[0m
\u001b[31mGem::FilePermissionError: You don't have write permissions for the
/usr/local/rvm/gems/ruby-2.5.1/wrappers directory.
\u001b[0m\u001b[0m\u001b[31mAn error occurred while installing rake (12.0.0), and Bundler
cannot continue.
Make sure that `gem install rake -v '12.0.0' --source 'https://rubygems.org/'`
succeeds before bundling.\u001b[0m

In Gemfile:
  rspec-rails was resolved to 3.1.0, which depends on
    railties was resolved to 5.2.2, which depends on
      rake\u001b[0m
container 4d66516f60d857874956d949f37205142fc26de579c8770fd8a177ec1d2e4dad is dead
Tue Dec 25 14:45:35 CET 2018

@yegor256
Copy link
Member

@rultor release, tag is 0.20.4

yegor256 added a commit that referenced this issue Dec 25, 2018
@rultor
Copy link
Collaborator

rultor commented Dec 25, 2018

@rultor release, tag is 0.20.4

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Dec 25, 2018

@rultor release, tag is 0.20.4

@yegor256 Done! FYI, the full log is here (took me 3min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants