Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpRack_Runner->getTestURL() problem with generation of the link. #90

Open
PavloTitenok opened this issue Oct 3, 2013 · 3 comments
Open

Comments

@PavloTitenok
Copy link
Contributor

There is problem with usage of the function which is not covered by the test. $_SERVER['REQUEST_URI'] includes parameters of the request. If use inside of the test REQUEST_URI is something like: /phprack.php?_=1380787672944&test=initialTestLabel&token=div%23d1

So $this->runner->getTestURL('targetTestLabel') will return:
/phprack.php?=1380787672944&test=initialTestLabe>&token=div%23d1?test=targetTestLabel

@yegor256
Copy link
Owner

yegor256 commented Oct 3, 2013

This is definitely a bug, thanks for reporting, I'll fix it soon..

@yegor256
Copy link
Owner

yegor256 commented Oct 4, 2013

@PavloTitenok please check whether it works after the fix

@davvd davvd reopened this Jan 6, 2014
@davvd
Copy link
Collaborator

davvd commented Jan 6, 2014

@yegor256 only @PavloTitenok can close this issue, since he opened it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants