#1097 findbugs removed

est/001.est

@@ -6,7 +6,6 @@ scope:
   2: Define interfaces and architecture
   3: Integrate Checkstyle
   4: Integrate PMD
-  5: Integrate Findbugs
   6: Integrate Codenarc
   7: Add custom checks/rules
   8: Add dependency analyser

pom.xml

@@ -43,7 +43,6 @@ OF THE POSSIBILITY OF SUCH DAMAGE.
   <modules>
     <module>qulice-ant</module>
     <module>qulice-checkstyle</module>
-    <module>qulice-findbugs</module>
     <module>qulice-maven-plugin</module>
     <module>qulice-pmd</module>
     <module>qulice-spi</module>

qulice-ant/pom.xml

@@ -68,11 +68,6 @@ OF THE POSSIBILITY OF SUCH DAMAGE.
         </exclusion>
       </exclusions>
     </dependency>
-    <dependency>
-      <groupId>com.qulice</groupId>
-      <artifactId>qulice-findbugs</artifactId>
-      <version>${project.version}</version>
-    </dependency>
     <dependency>
       <groupId>com.qulice</groupId>
       <artifactId>qulice-spi</artifactId>
@@ -112,11 +107,10 @@ OF THE POSSIBILITY OF SUCH DAMAGE.
         <configuration combine.children="append">
           <mergeUserSettings>false</mergeUserSettings>
           <pomIncludes>
-            <pomInclude>findbugs-violations/pom.xml</pomInclude>
+            <pomInclude>violations/pom.xml</pomInclude>
           </pomIncludes>
           <extraArtifacts>
             <extraArtifact>${project.groupId}:qulice-checkstyle:${project.version}:jar</extraArtifact>
-            <extraArtifact>${project.groupId}:qulice-findbugs:${project.version}:jar</extraArtifact>
             <extraArtifact>${project.groupId}:qulice-pmd:${project.version}:jar</extraArtifact>
             <extraArtifact>${project.groupId}:qulice-spi:${project.version}:jar</extraArtifact>
           </extraArtifacts>
@@ -127,11 +121,6 @@ OF THE POSSIBILITY OF SUCH DAMAGE.
             <artifactId>qulice-checkstyle</artifactId>
             <version>${project.version}</version>
           </dependency>
-          <dependency>
-            <groupId>${project.groupId}</groupId>
-            <artifactId>qulice-findbugs</artifactId>
-            <version>${project.version}</version>
-          </dependency>
           <dependency>
             <groupId>${project.groupId}</groupId>
             <artifactId>qulice-pmd</artifactId>

qulice-ant/src/it/findbugs-violations/pom.xml → qulice-ant/src/it/violations/pom.xml

@@ -36,10 +36,10 @@ OF THE POSSIBILITY OF SUCH DAMAGE.
     <version>0.54.1</version>
   </parent>
   <groupId>com.qulice.plugin</groupId>
-  <artifactId>findbugs-violations</artifactId>
+  <artifactId>violations</artifactId>
   <version>1.0-SNAPSHOT</version>
   <packaging>jar</packaging>
-  <name>findbugs-violations</name>
+  <name>violations</name>
   <build>
     <plugins>
       <plugin>

qulice-ant/src/it/findbugs-violations/src/main/java/com/qulice/foo/Main.java → qulice-ant/src/it/violations/src/main/java/com/qulice/foo/Main.java

@@ -48,7 +48,7 @@ public final class Main {
      * Test something.
      */
     public Main() {
-        this.list = new HashSet<URL>();
+        this.list = new HashSet<URL>(500);
     }
 
     /**

qulice-maven-plugin/src/it/findbugs-violations/verify.groovy → qulice-ant/src/it/violations/verify.groovy

@@ -33,4 +33,4 @@
  */
 
 def log = new File(basedir, 'build.log')
-assert log.text.contains('com.qulice.foo.Main.list is or uses a map or set of URLs, which can be a performance hog')
+assert log.text.contains('MagicNumberCheck')

qulice-ant/src/main/java/com/qulice/ant/QuliceTask.java

@@ -31,7 +31,6 @@
 
 import com.jcabi.log.Logger;
 import com.qulice.checkstyle.CheckstyleValidator;
-import com.qulice.findbugs.FindBugsValidator;
 import com.qulice.pmd.PmdValidator;
 import com.qulice.spi.Environment;
 import com.qulice.spi.ResourceValidator;
@@ -97,21 +96,21 @@ public void setClasspath(final Path clsspth) {
     public void execute() {
         super.execute();
         final Environment env = this.environment();
+        final long start = System.nanoTime();
         try {
-            final long start = System.nanoTime();
             QuliceTask.validate(env);
-            Logger.info(
-                this,
-                "Qulice quality check completed in %[nano]s",
-                System.nanoTime() - start
-            );
         } catch (final ValidationException ex) {
             Logger.info(
                 this,
                 "Read our quality policy: http://www.qulice.com/quality.html"
             );
             throw new BuildException("Failure", ex);
         }
+        Logger.info(
+            this,
+            "Qulice quality check completed in %[nano]s, no errors",
+            System.nanoTime() - start
+        );
     }
 
     /**
@@ -166,16 +165,19 @@ private static void validate(final Environment env)
         for (final Validator validator : QuliceTask.validators()) {
             validator.validate(env);
         }
+        if (!results.isEmpty()) {
+            throw new ValidationException(
+                String.format("%d violations, see log above", results.size())
+            );
+        }
     }
 
     /**
      * Create collection of validators.
      * @return Collection of validators.
      */
     private static Collection<Validator> validators() {
-        return Arrays.<Validator>asList(
-            new FindBugsValidator()
-        );
+        return Arrays.asList();
     }
 
     /**