#659:fixed tests according to new rule

yegor256 · Feb 20, 2016 · 9302a52 · 9302a52
1 parent b6059f3
commit 9302a52
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 33 deletions.
diff --git a/...aven-plugin/src/it/dependency-violations-exclude/src/main/java/com/qulice/foo/Sample.java b/...aven-plugin/src/it/dependency-violations-exclude/src/main/java/com/qulice/foo/Sample.java
@@ -14,18 +14,13 @@
  * @since 1.0
  */
 public final class Sample {
-    /**
-     * Utility constructor.
-     */
-    private Sample() {
-        // do nothing
-    }
 
     /**
      * Test method.
      * @return Stream.
+     * @checkstyle NonStaticMethod (2 lines)
      */
-    public static InputStream test() {
+    public InputStream test() {
         return IOUtils.toInputStream("oops");
     }
 }
diff --git a/qulice-maven-plugin/src/it/dependency-violations/src/main/java/com/qulice/foo/Sample.java b/qulice-maven-plugin/src/it/dependency-violations/src/main/java/com/qulice/foo/Sample.java
@@ -14,18 +14,13 @@
  * @since 1.0
  */
 public final class Sample {
-    /**
-     * Utility constructor.
-     */
-    private Sample() {
-        // do nothing
-    }
 
     /**
      * Test method.
      * @return Stream.
+     * @checkstyle NonStaticMethod (2 lines)
      */
-    public static InputStream test() {
+    public InputStream test() {
         return IOUtils.toInputStream("oops");
     }
 }
diff --git a/...ce-maven-plugin/src/it/hibernate-validator-check/src/main/java/com/qulice/foo/Sample.java b/...ce-maven-plugin/src/it/hibernate-validator-check/src/main/java/com/qulice/foo/Sample.java
@@ -11,18 +11,13 @@
  * @since 1.0
  */
 public final class Sample {
-    /**
-     * Utility constructor.
-     */
-    private Sample() {
-        // do nothing
-    }
 
     /**
      * Test method.
      * @return Stream.
+     * @checkstyle NonStaticMethod (2 lines)
      */
-    public static String test() {
+    public String test() {
         return "oops";
     }
 }
diff --git a/...aven-plugin/src/it/multi-module/mod-alpha/src/main/java/com/qulice/plugin/alpha/Main.java b/...aven-plugin/src/it/multi-module/mod-alpha/src/main/java/com/qulice/plugin/alpha/Main.java
@@ -36,6 +36,7 @@
  * @version $Id$
  * @since 1.0
  */
+@SuppressWarnings("PMD.ProhibitPublicStaticMethods")
 public final class Main {
     /**
      * Utility constructor.

diff --git a/qulice-maven-plugin/src/it/pmd-violations/src/main/java/com/qulice/foo/Violations.java b/qulice-maven-plugin/src/it/pmd-violations/src/main/java/com/qulice/foo/Violations.java
@@ -41,53 +41,50 @@ public final class Violations {
      */
     private Integer var;
 
-    /**
-     * Utility constructor.
-     */
-    private Violations() {
-        // do nothing
-    }
-
     /**
      * Calculate square of a number.
      * @param num The number
      * @return The square
+     * @checkstyle NonStaticMethod (2 lines)
      */
-    public static int square(final int num) {
+    public int square(final int num) {
         return num * num;
     }
 
     /**
      * Returns Foo.
      * @return Foo.
+     * @checkstyle NonStaticMethod (2 lines)
      */
-    public static Foo doSmth() {
+    public Foo doSmth() {
         final String name = "test".toUpperCase();
         return new Foo(name);
     }
 
     /**
      * Returns Foo again.
      * @return Foo.
+     * @checkstyle NonStaticMethod (2 lines)
      */
-    public static Foo doSmthElse() {
+    public Foo doSmthElse() {
         String name = "other";
         name = String.format("%s append", name);
         return new Foo(name);
     }
 
     /**
      * Prints something.
+     * @checkstyle NonStaticMethod (2 lines)
      */
-    public static void print() {
+    public void print() {
         final String message = "hello";
         System.out.println(message);
     }
 
     /**
      * Test class.
      */
-    private static final class Foo {
+    private final class Foo {
         /**
          * Name.
          */