Skip to content

Commit

Permalink
Merge branch '__rultor'
Browse files Browse the repository at this point in the history
  • Loading branch information
rultor committed Dec 12, 2023
2 parents b8c8fe6 + 58de2a9 commit 9a1cf8b
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 34 deletions.
Expand Up @@ -38,8 +38,6 @@ public final class Brackets {

/**
* Simple method.
* @todo #123 Make this better
* in multiple lines but different.
*/
public void wrongBrackets() {
new Foo(null, new int[]{1},
Expand All @@ -61,8 +59,6 @@ private void call(final String start, final String end) {

/**
* Check brackets structure.
* @todo #123 Make this better
* in multiple lines.
*/
private final class Foo {

Expand Down

This file was deleted.

Expand Up @@ -38,14 +38,13 @@ assert log.text.contains('Tabs.java[4]: Line contains a tab character. (FileTabC
assert log.text.contains('tabs.txt[1]: Line contains a tab character. (FileTabCharacterCheck)')
assert log.text.findAll('Brackets.java.*(HeaderCheck)').empty
//assert log.text.contains('Violations.java[6]: This method must be static, because it does not refer to "this"')
assert log.text.contains('Brackets.java[55]: Closing bracket should be on a new line (BracketsStructureCheck)')
assert log.text.contains('Brackets.java[53]: Closing bracket should be on a new line (BracketsStructureCheck)')
assert log.text.contains('Violations.java[14]: Parameter txt should be final. (FinalParametersCheck)')
assert log.text.contains('Violations.java[25]: Parameter ex should be final. (FinalParametersCheck)')
assert log.text.contains('NewLines.java[4]: Lines in file should end with Unix-like end of line')
assert log.text.contains('newlines.txt[3]: Lines in file should end with Unix-like end of line')
assert log.text.contains('Violations.java[33]: ArrayList should be initialized with a size parameter')
assert log.text.contains('Violations.java[34]: ArrayList should be initialized with a size parameter')
assert log.text.findAll('Pdd.java.*: .todo tag has wrong format').empty
assert !log.text.contains('Got an exception - java.lang.NullPointerException')
assert log.text.findAll('SomeTest.java .+ (JavadocMethodCheck)').isEmpty()
assert !log.text.contains('IndentationChecks.java[19]: method call rparen at indentation level 12')

4 comments on commit 9a1cf8b

@0pdd
Copy link
Collaborator

@0pdd 0pdd commented on 9a1cf8b Dec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 123-1f09aa3b disappeared from qulice-maven-plugin/src/it/checkstyle-violations/src/main/java/com/qulice/plugin/violations/Brackets.java), that's why I closed #1119. Please, remember that the puzzle was not necessarily removed in this particular commit. Maybe it happened earlier, but we discovered this fact only now.

@0pdd
Copy link
Collaborator

@0pdd 0pdd commented on 9a1cf8b Dec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 123-b644cf22 disappeared from qulice-maven-plugin/src/it/checkstyle-violations/src/main/java/com/qulice/plugin/violations/Brackets.java), that's why I closed #1120. Please, remember that the puzzle was not necessarily removed in this particular commit. Maybe it happened earlier, but we discovered this fact only now.

@0pdd
Copy link
Collaborator

@0pdd 0pdd commented on 9a1cf8b Dec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 123-cfed8d02 disappeared from qulice-maven-plugin/src/it/checkstyle-violations/src/main/java/com/qulice/plugin/violations/Pdd.java), that's why I closed #1121. Please, remember that the puzzle was not necessarily removed in this particular commit. Maybe it happened earlier, but we discovered this fact only now.

@0pdd
Copy link
Collaborator

@0pdd 0pdd commented on 9a1cf8b Dec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 123-5357374c disappeared from qulice-maven-plugin/src/it/checkstyle-violations/src/main/java/com/qulice/plugin/violations/Pdd.java), that's why I closed #1122. Please, remember that the puzzle was not necessarily removed in this particular commit. Maybe it happened earlier, but we discovered this fact only now.

Please sign in to comment.