#1092 parent 0.59.0

yegor256 · Jul 13, 2022 · c2d778d · c2d778d
1 parent a33b127
commit c2d778d
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 5 deletions.
diff --git a/pom.xml b/pom.xml
@@ -33,7 +33,7 @@ OF THE POSSIBILITY OF SUCH DAMAGE.
   <parent>
     <groupId>com.jcabi</groupId>
     <artifactId>parent</artifactId>
-    <version>0.57.2</version>
+    <version>0.59.0</version>
   </parent>
   <groupId>com.qulice</groupId>
   <artifactId>qulice</artifactId>
@@ -96,6 +96,11 @@ OF THE POSSIBILITY OF SUCH DAMAGE.
   </distributionManagement>
   <dependencyManagement>
     <dependencies>
+      <dependency>
+        <groupId>org.antlr</groupId>
+        <artifactId>antlr4-runtime</artifactId>
+        <version>4.9.2</version>
+      </dependency>
       <dependency>
         <groupId>org.projectlombok</groupId>
         <artifactId>lombok</artifactId>

diff --git a/qulice-checkstyle/pom.xml b/qulice-checkstyle/pom.xml
@@ -152,6 +152,7 @@ OF THE POSSIBILITY OF SUCH DAMAGE.
               <excludes combine.children="append">
                 <exclude>checkstyle:/src/test/resources/com/qulice/checkstyle/.*</exclude>
                 <exclude>pmd:.*/src/test/resources/.*</exclude>
+                <exclude>dependencies:org.antlr</exclude>
                 <exclude>xml:/src/main/resources/com/qulice/checkstyle/checks.xml</exclude>
                 <exclude>xml:/src/test/resources/com/qulice/checkstyle/ChecksTest/.*</exclude>
               </excludes>

diff --git a/qulice-maven-plugin/src/main/java/com/qulice/maven/DependenciesValidator.java b/qulice-maven-plugin/src/main/java/com/qulice/maven/DependenciesValidator.java
@@ -50,6 +50,7 @@
  * Validator of dependencies.
  *
  * @since 0.3
+ * @checkstyle ReturnCountCheck (100 line)
  */
 final class DependenciesValidator implements MavenValidator {
 
@@ -62,13 +63,14 @@ final class DependenciesValidator implements MavenValidator {
     public void validate(final MavenEnvironment env)
         throws ValidationException {
         final Collection<String> excludes = env.excludes("dependencies");
-        if (!env.outdir().exists()
-            || "pom".equals(env.project().getPackaging())
-            || excludes.contains(".*")
-            ) {
+        if (!env.outdir().exists() || "pom".equals(env.project().getPackaging())) {
             Logger.info(this, "No dependency analysis in this project");
             return;
         }
+        if (excludes.contains(".*")) {
+            Logger.info(this, "Dependency analysis suppressed in the project via pom.xml");
+            return;
+        }
         final Collection<String> unused = Collections2.filter(
             DependenciesValidator.unused(env),
             Predicates.not(new DependenciesValidator.ExcludePredicate(excludes))
@@ -93,6 +95,13 @@ public void validate(final MavenEnvironment env)
                 StringUtils.join(used, DependenciesValidator.SEP)
             );
         }
+        if (!used.isEmpty() || !unused.isEmpty()) {
+            Logger.info(
+                this,
+                // @checkstyle LineLength (1 line)
+                "You can suppress this message by <exclude>dependencies:...</exclude> in pom.xml, where <...> is what the dependency name starts with (not a regular expression!)"
+            );
+        }
         final int failures = used.size() + unused.size();
         if (failures > 0) {
             throw new ValidationException(