Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BracketsStructureCheck is not validated with ChecksIT #29

Closed
yegor256 opened this issue Apr 21, 2013 · 11 comments
Closed

BracketsStructureCheck is not validated with ChecksIT #29

yegor256 opened this issue Apr 21, 2013 · 11 comments
Assignees

Comments

@yegor256
Copy link
Owner

migrated from Trac, where originally posted by yegor256 on 24-Oct-2011 7:51pm

related to #16

BracketsStructureCheck is not validated in ChecksIT. We should test it like we do with other checks. The budget is 1 hour.

@ghost ghost assigned yegor256 Apr 21, 2013
@yegor256
Copy link
Owner Author

migrated from Trac, where originally posted by yegor256 on 24-Oct-2011 7:52pm

Dmitry, this ticket is for you.

@yegor256
Copy link
Owner Author

migrated from Trac, where originally posted by dmitry.bashkin on 31-Oct-2011 3:17pm

In [219/qulice]:

#CommitTicketReference repository="qulice" revision="219"
refs #29 - new branch

@yegor256
Copy link
Owner Author

migrated from Trac, where originally posted by dmitry.bashkin on 1-Nov-2011 10:23am

In [220/qulice]:

#CommitTicketReference repository="qulice" revision="220"
refs #29 - done

@yegor256
Copy link
Owner Author

migrated from Trac, where originally posted by dmitry.bashkin on 1-Nov-2011 10:28am

In [221/qulice]:

#CommitTicketReference repository="qulice" revision="221"
refs #29 - resync with trunk

@yegor256
Copy link
Owner Author

migrated from Trac, where originally posted by dmitry.bashkin on 1-Nov-2011 10:35am

I realized it in the following way:
if number of opening brackets is lager than closing ones than the line must end with "("
else if number of closing brackets is lager than opening ones than the line must end with ")" or ");"
So ") {" won't do. Is it correct?
And please validate that this check is tested.

@yegor256
Copy link
Owner Author

migrated from Trac, where originally posted by yegor256 on 1-Nov-2011 9:49pm

Very good job! Let's try to merge it into trunk...

@yegor256
Copy link
Owner Author

migrated from Trac, where originally posted by guard on 1-Nov-2011 9:56pm

In [228/qulice]:

#CommitTicketReference repository="qulice" revision="228"
refs #29 - /branches/ticket29 merged into /trunk, 1 hours spent

@yegor256
Copy link
Owner Author

migrated from Trac, where originally posted by guard on 1-Nov-2011 9:56pm

In [229/qulice]:

#CommitTicketReference repository="qulice" revision="229"
refs #29 - /branches/ticket29 successfully closed

@yegor256
Copy link
Owner Author

migrated from Trac, where originally posted by yegor256 on 1-Nov-2011 10:05pm

Thanks!

@yegor256
Copy link
Owner Author

migrated from Trac, where originally posted by yegor256 on 22-Jan-2012 11:39pm

Milestone PROTOTYPE deleted

@yegor256
Copy link
Owner Author

migrated from Trac, where originally posted by yegor on 21-Apr-2013 12:03pm

we moved to Github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant