Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavadocTagsCheck doesn't validate all author tags #495

Closed
krzyk opened this issue Nov 16, 2015 · 16 comments
Closed

JavadocTagsCheck doesn't validate all author tags #495

krzyk opened this issue Nov 16, 2015 · 16 comments
Labels

Comments

@krzyk
Copy link
Collaborator

krzyk commented Nov 16, 2015

Following example:

**
 * Simple.
 * @author John Smith (john.smith@example.com)
 * @author None
 * @version $Id$
 */
public interface AuthorTag {
}

Should fail, because second author has incorrect format (it doesn't have an email address), but it doesn't.
When you change order of author tags, JavadocTagsCheck will fail.
Fix JavadocTagsCheck to check all @author tags.

@krzyk
Copy link
Collaborator Author

krzyk commented Nov 17, 2015

@davvd valid bug

@davvd davvd added the bug label Nov 18, 2015
@davvd
Copy link

davvd commented Nov 18, 2015

@davvd valid bug

@krzyk I added bug tag to this ticket

@davvd
Copy link

davvd commented Nov 18, 2015

@krzyk many thanks for the report, I topped your account for 30 mins, transaction 70054478

@davvd davvd added DEV labels Nov 18, 2015
@krzyk
Copy link
Collaborator Author

krzyk commented Nov 28, 2015

@davvd this is postponed

@davvd
Copy link

davvd commented Nov 30, 2015

@davvd this is postponed

@krzyk right, I added "postponed" label

@davvd
Copy link

davvd commented Nov 30, 2015

@davvd this is postponed

@krzyk I will assign somebody else to this issue

@mkordas
Copy link
Contributor

mkordas commented Dec 31, 2015

@krzyk can you assign me here?

@krzyk
Copy link
Collaborator Author

krzyk commented Dec 31, 2015

@davvd assign @mkordas please

@krzyk
Copy link
Collaborator Author

krzyk commented Dec 31, 2015

@davvd this is not postponed

@davvd
Copy link

davvd commented Jan 1, 2016

@davvd assign @mkordas please

@krzyk done. @mkordas the task is yours, please go ahead

@davvd davvd removed the postponed label Jan 1, 2016
@davvd
Copy link

davvd commented Jan 1, 2016

@davvd this is not postponed

@krzyk sure, thanks, I removed "postponed" tag to it

@davvd davvd mentioned this issue Jan 1, 2016
mkordas added a commit to mkordas/qulice that referenced this issue Jan 1, 2016
 For yegor256#495:
 * Instead of validating only first Javadoc tag, all of them are gathered to the `List` and then validated
 * Test is added to confirm the behaviour
@mkordas
Copy link
Contributor

mkordas commented Jan 1, 2016

@davvd please see PR #573

@davvd
Copy link

davvd commented Jan 4, 2016

@davvd please see PR #573

@mkordas will take a look, thanks

mkordas added a commit to mkordas/qulice that referenced this issue Jan 4, 2016
mkordas added a commit to mkordas/qulice that referenced this issue Jan 4, 2016
@mkordas
Copy link
Contributor

mkordas commented Jan 4, 2016

@krzyk this was merged in #573, can you close the issue?

@krzyk
Copy link
Collaborator Author

krzyk commented Jan 4, 2016

@mkordas thanks

@krzyk krzyk closed this as completed Jan 4, 2016
@davvd
Copy link

davvd commented Jan 6, 2016

@mkordas done, I added 30 mins in payment 568cea2e2310ad21f7000311, 98 hours and 23 mins spent to complete this

added +30 to your rating, now it is equal to +1375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants