-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logging mechanism should be improved and unified #61
Comments
migrated from Trac, where originally posted by dpetruha on 24-Nov-2011 10:04am Another redesign task to solve #42 |
migrated from Trac, where originally posted by yegor256 on 24-Nov-2011 11:27am Let's wait for #44 |
migrated from Trac, where originally posted by yegor256 on 27-Nov-2011 10:17am Thanks for reporting it, 1/2hrs are yours. |
migrated from Trac, where originally posted by yegor256 on 27-Nov-2011 10:25am I'm suggesting to improve it this way. First,
Then, we add this interface:
and a class
Then, every validator will do literally this:
Looks good? |
migrated from Trac, where originally posted by yegor256 on 27-Nov-2011 10:27am Validators won't log any events directly any more. They will just add violations to the collection. All reporting will be done in one place, in |
migrated from Trac, where originally posted by yegor256 on 27-Nov-2011 10:29am Moreover, we can get rid of
Looks even better for me. What do you think? |
migrated from Trac, where originally posted by yegor256 on 13-Dec-2011 1:04pm Dmitry, can you implement this refactoring? The budget is 1 hour. |
migrated from Trac, where originally posted by dmitry.bashkin on 14-Dec-2011 10:05am In [402/qulice]:
|
migrated from Trac, where originally posted by dmitry.bashkin on 14-Dec-2011 2:36pm What to do with files that are not compiled, for example CheckstyleValidator: |
migrated from Trac, where originally posted by yegor256 on 22-Jan-2012 11:39pm Milestone PROTOTYPE deleted |
migrated from Trac, where originally posted by yegor256 on 1-Apr-2012 6:11pm Dmitry is no longer in the project, I'll implement this myself |
migrated from Trac, where originally posted by yegor256 on 2-Apr-2012 4:22am In [503/qulice]:
|
migrated from Trac, where originally posted by yegor256 on 2-Apr-2012 4:23am In [504/qulice]:
|
migrated from Trac, where originally posted by yegor256 on 2-Apr-2012 4:23am In [505/qulice]:
|
migrated from Trac, where originally posted by yegor256 on 2-Apr-2012 4:33am In [506/qulice]:
|
migrated from Trac, where originally posted by yegor256 on 2-Apr-2012 4:37am In [507/qulice]:
|
migrated from Trac, where originally posted by yegor256 on 2-Apr-2012 5:01am In [508/qulice]:
|
migrated from Trac, where originally posted by yegor256 on 2-Apr-2012 5:02am In [509/qulice]:
|
migrated from Trac, where originally posted by yegor256 on 2-Apr-2012 6:15am In [510/qulice]:
|
migrated from Trac, where originally posted by yegor256 on 24-May-2012 1:14pm let's do it in the next version |
migrated from Trac, where originally posted by yegor on 21-Apr-2013 12:03pm we moved to Github |
@yegor256 is this still valid? |
@krzyk up to you. I think, the idea is interesting. you decide. |
@davvd it is a valid bug |
@yegor256 thank you for reporting this, I added 15 mins to your acc, transaction |
@davvd this is not postponed |
@yegor256 initial batch has been merged to master (checkstyle uses new logging, others are in todos), please close this issue if it is OK |
@krzyk thanks! |
migrated from Trac, where originally posted by dpetruha on 24-Nov-2011 10:03am
a) to get resource validators from ValidatorsProvider (method to get such validators will be added in #44)
b) if a) returns any resource validators then get list of files to be checked (should be all files of the target project under src folder).
c) iterate over that list of files then iterate over each resource validator returned from a) and send current file to the current resource validator for validation (i.e.
call ResourceValidator.validate method).
d) If ResourceValidator.validate returns ResourceValidationResult that is failed then log returned error with
com.ymock.util.Logger.error()
specifying validation resource (path should be relative to
this.session.getExecutionRootDirectory()), line number if present in validation result, error message if present in validation result.
e) after validation of all files is over if any validation failed throw MojoFailureException
- ~~`61-654de8aa`/#741~~ (by Krzysztof Krason) - `61-61fa67ee`/#742 (by ) - `61-1d39a5c7`/#746 (by Krzysztof Krason) - `61-832eca62`/#740 (by ) - `61-1e86e587`/#745 (by )
The text was updated successfully, but these errors were encountered: