Qulice allows catch parameters not following naming convention

[mkordas]

Currently Qulice does not complain on the following catch parameter names:

try {
    ...
} catch(IllegalStateException ex_invalid_1) {
    ...
}
try {
    ...
} catch(IllegalStateException $xxx) {
    ...
}

I'd expect violation on both of these names. Only ex or 3-12 lowercase latin characters should be allowed.

Pattern should be ^(ex|[a-z]{3,12})$. Moreover, rest of patterns should be unified to follow the convention: replace ^id$|^[a-z]{3,12}$ with ^(id|[a-z]{3,12})$ in LocalFinalVariableName, LocalVariableName, MemberName, ParameterName.

[krzyk]

@mkordas doesn't it work already?

        <module name="CatchParameterName">
            <property name="format" value="^ex|[a-z]{3,12}$"/>
        </module>

Is this configuration wrong?

[mkordas]

@krzyk both names are matching our regex: http://regexr.com/3cki7

[krzyk]

@mkordas so the () are missing, strange, those shouldn't be required, but they are.
Could you also add to the description that we should follow the convention of ^(ex|[a-z]{3,12})$ and replace all^id$|^[a-z]{3,12}$ with ^(id|[a-z]{3,12})$ (so the list includes LocalFinalVariableName, LocalVariableName, MemberName, ParameterName)?

[krzyk]

@mkordas ping

[mkordas]

@krzyk done, thanks for pinging

[krzyk]

@davvd valild bug

[krzyk]

@davvd valid bug

[krzyk]

@davvd this is postponed

[davvd]

@davvd valild bug

@krzyk tagged this issue with "bug"

[davvd]

@davvd valid bug

@krzyk added "bug" tag to this issue

[davvd]

@davvd this is postponed

@krzyk right, I added "postponed" label

[davvd]

@davvd this is postponed

@krzyk got it, someone else will be assigned soon

[davvd]

@mkordas thanks for the report, I topped your acc for 15 mins, payment ID 56a5fb478cc94d3272000322

[krzyk]

@davvd this is not postponed

[krzyk]

@davvd assign @kitsook

[davvd]

@davvd this is not postponed

@krzyk sure, thanks, I removed "postponed" tag to it

[davvd]

@davvd assign @kitsook

@krzyk done. @kitsook you are assigned to this task. please proceed...

[kitsook]

@krzyk the regular expressions of LocalFinalVariableName, LocalVariableName, MemberName, and ParameterName are working fine and do not require changes

^id$|^[a-z]{3,12}$ works because it means there are two alternatives:

• between line start and end, contain "id"
• between line start and end, contain 3 to 12 lowercase alphabets

^ex|[a-z]{3,12}$ of CatchParameterName doesn't work as expected as it means there are two alternatives:

• line start with "ex"
• line end with 3 to 12 lowercase alphabets

^ex|[a-z]{3,12}$ can be fixed with ^ex$|^[a-z]{3,12}$ or the proposed ^(ex|[a-z]{3,12})$

[krzyk]

@kitsook let's make all the regexes you mentioned to the ^(...)$ convention, it is more readable, also we need a test for the CatchParameterName so we will be sure there won't be any regression

[kitsook]

@Dvvd PR #651 created

[kitsook]

@mkordas PR #651 merged. Please close the issue

[mkordas]

@kitsook thanks!

[davvd]

@kitsook 38 mins was added to your account, many thanks for your contribution (payment AP-5BA49698PH173703C)! The task took 70 hours and 22 mins.

m=4222, that's why a bonus here for fast delivery

+38 added to your rating, current score is: +98