Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultMavenEnvironmentTest.java:136-143: Ideally integration test is required... #699

Closed
davvd opened this issue Feb 10, 2016 · 10 comments
Closed
Assignees
Labels

Comments

@davvd
Copy link

davvd commented Feb 10, 2016

Puzzle 676-be080182 in qulice-maven-plugin/src/test/java/com/qulice/maven/DefaultMavenEnvironmentTest.java:136-143 has to be resolved: Ideally integration test is required to reproduce NPE in issue #676. To reproduce problem firstly revert changes marked with #676, then add to pom.xml of IT project at least one exclude rule in configuration.excludes block and dependency (in my case worked org.hibernate:hibernate-annotations:3.5.6-Final). Suggestion is that dependency must be compile-time scope as far as JUnit didn't work as test-scope dependency.... The puzzle was created by Viktor Kuchyn on 9-Feb-2016.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code.

@davvd
Copy link
Author

davvd commented Feb 10, 2016

@dskalenko please pick this up, and keep in mind these instructions. Any technical questions - ask right here. 30 mins is the budget of the task. This is exactly how much will be paid when the problem is solved (no matter how much time you will actually spend). See this for more information

@davvd davvd added the IMP label Feb 10, 2016
dskalenko added a commit to dskalenko/qulice that referenced this issue Feb 19, 2016
@dskalenko
Copy link
Contributor

@davvd here is the PR #722

@dskalenko
Copy link
Contributor

@davvd need more time for code review

@davvd
Copy link
Author

davvd commented Feb 24, 2016

@davvd here is the PR #722

@dskalenko will take a look, thanks

@davvd
Copy link
Author

davvd commented Feb 24, 2016

@davvd need more time for code review

@dskalenko of course, thanks for letting me know, take your time

dskalenko added a commit to dskalenko/qulice that referenced this issue Feb 28, 2016
dskalenko added a commit to dskalenko/qulice that referenced this issue Feb 28, 2016
…ation test is required revert changes of PUZZLES file
dskalenko added a commit to dskalenko/qulice that referenced this issue Feb 29, 2016
dskalenko added a commit to dskalenko/qulice that referenced this issue Feb 29, 2016
dskalenko added a commit to dskalenko/qulice that referenced this issue Mar 2, 2016
dskalenko added a commit to dskalenko/qulice that referenced this issue Mar 2, 2016
dskalenko added a commit to dskalenko/qulice that referenced this issue Mar 2, 2016
…ation test is required(add new line to the end of the files)
@krzyk
Copy link
Collaborator

krzyk commented Mar 2, 2016

@davvd this is not urgent

@davvd
Copy link
Author

davvd commented Mar 4, 2016

@davvd this is not urgent

@krzyk thanks, I removed the "urgent" tag

@davvd davvd added urgent and removed urgent labels Mar 4, 2016
@davvd
Copy link
Author

davvd commented Mar 7, 2016

@krzyk I am closing it, thanks all

@davvd davvd closed this as completed Mar 7, 2016
@davvd
Copy link
Author

davvd commented Mar 7, 2016

@dskalenko I added 30 mins to your account, many thanks for working with the project (79409485)! The completion time here was 552 hours and 14 mins.; +30 added to your rating, current score is: +105

@krzyk
Copy link
Collaborator

krzyk commented Jun 28, 2016

@davvd this is not urgent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants