Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade qulice to 0.16.2 #709

Closed
krzyk opened this issue Feb 14, 2016 · 34 comments
Closed

Upgrade qulice to 0.16.2 #709

krzyk opened this issue Feb 14, 2016 · 34 comments
Assignees
Labels

Comments

@krzyk
Copy link
Collaborator

krzyk commented Feb 14, 2016

Let's upgrade our own qulice from 0.15.4 to 0.16.2 and:

  • remove all unnecessary transient keywords.
  • remove all LineLength excludes before lines with URLs (e.g. in qulice-checkstyle/src/main/java/com/qulice/checkstyle/JavadocTagsCheck.java)
@krzyk
Copy link
Collaborator Author

krzyk commented Feb 14, 2016

@davvd valid bug

@davvd
Copy link

davvd commented Feb 15, 2016

@davvd valid bug

@krzyk tag bug added to this issue

@davvd
Copy link

davvd commented Mar 2, 2016

@krzyk thanks for the ticket, your account was topped for 30 mins, payment 79173443

@krzyk
Copy link
Collaborator Author

krzyk commented Mar 6, 2016

@davvd this is postponed

@davvd
Copy link

davvd commented Mar 7, 2016

@davvd this is postponed

@krzyk got it, "postponed" label here

@davvd davvd added the postponed label Mar 7, 2016
@davvd
Copy link

davvd commented Mar 7, 2016

@davvd this is postponed

@krzyk no problem, I will try to find somebody else

@krzyk
Copy link
Collaborator Author

krzyk commented Mar 12, 2016

@davvd this is not postponed

@krzyk
Copy link
Collaborator Author

krzyk commented Mar 12, 2016

@davvd assign @vkuchyn

@davvd davvd removed the postponed label Mar 14, 2016
@davvd
Copy link

davvd commented Mar 14, 2016

@davvd this is not postponed

@krzyk OK, I un-labeled it as "postponed" tag

@davvd
Copy link

davvd commented Mar 14, 2016

@davvd assign @vkuchyn

@krzyk OK @vkuchyn please proceed, this task is yours

@vkuchyn
Copy link
Contributor

vkuchyn commented Mar 15, 2016

@krzyk file DuplicateFinderValidator
Has violation - not proper order, @checkstyle must be after @todo (AtclauseOrderCheck). But if to remove checkstyle annotation - we gets Line is too long (LineLengthCheck), about @todo description. This case blocks an issue. I see 2 possible decisions:

  1. Create an issue to fix line length check like it was done for @see annotation
  2. Split @todo description to fit 80 characters (this will reduce readability).
    What will you suggest?

@vkuchyn
Copy link
Contributor

vkuchyn commented Mar 15, 2016

@davvd I am blocked with #709 (comment)

@krzyk
Copy link
Collaborator Author

krzyk commented Mar 15, 2016

@vkuchyn I would go with spliting the todo to fit 80 characters (except the URLs, those should work without wrapping)

@vkuchyn
Copy link
Contributor

vkuchyn commented Mar 15, 2016

@krzyk ok, thanks

vkuchyn added a commit to vkuchyn/qulice that referenced this issue Mar 15, 2016
vkuchyn added a commit to vkuchyn/qulice that referenced this issue Mar 15, 2016
vkuchyn added a commit to vkuchyn/qulice that referenced this issue Mar 15, 2016
@vkuchyn vkuchyn mentioned this issue Mar 15, 2016
Merged
vkuchyn added a commit to vkuchyn/qulice that referenced this issue Mar 15, 2016
vkuchyn added a commit to vkuchyn/qulice that referenced this issue Mar 15, 2016
vkuchyn added a commit to vkuchyn/qulice that referenced this issue Mar 15, 2016
vkuchyn added a commit to vkuchyn/qulice that referenced this issue Mar 15, 2016
vkuchyn added a commit to vkuchyn/qulice that referenced this issue Mar 15, 2016
vkuchyn added a commit to vkuchyn/qulice that referenced this issue Mar 15, 2016
vkuchyn added a commit to vkuchyn/qulice that referenced this issue Mar 15, 2016
@vkuchyn
Copy link
Contributor

vkuchyn commented Mar 15, 2016

@davvd fixed in #753. Need to review

@davvd
Copy link

davvd commented Mar 16, 2016

@davvd fixed in #753. Need to review

@vkuchyn thank you

@davvd
Copy link

davvd commented Mar 29, 2016

@vkuchyn you're working with this issue for 15 days already. -30 added to your rating, current score is: +150

@krzyk
Copy link
Collaborator Author

krzyk commented Mar 29, 2016

@davvd please give more time here

@vkuchyn
Copy link
Contributor

vkuchyn commented Mar 30, 2016

@davvd I was waiting for CR for PR #753 15 days. What behaviour should be in this case not to be penalized?

@vkuchyn
Copy link
Contributor

vkuchyn commented Mar 30, 2016

@davvd need more time

@davvd
Copy link

davvd commented Mar 30, 2016

@davvd please give more time here

@krzyk OK, take your time

@davvd
Copy link

davvd commented Mar 30, 2016

@davvd need more time

@vkuchyn yeah, I know, take your time

@krzyk
Copy link
Collaborator Author

krzyk commented Apr 7, 2016

@davvd assign @vkuchyn

@davvd
Copy link

davvd commented Apr 11, 2016

@davvd assign @vkuchyn

@krzyk there too many active tasks (3) already in the project, can't assign more

@vkuchyn
Copy link
Contributor

vkuchyn commented Apr 11, 2016

@davvd Task is almost done, PR created, we all are waiting for reviewer )

@davvd
Copy link

davvd commented Apr 13, 2016

@davvd Task is almost done, PR created, we all are waiting for reviewer )

@vkuchyn OK

@krzyk
Copy link
Collaborator Author

krzyk commented May 27, 2016

@davvd this is urgent

@davvd davvd added the urgent label May 27, 2016
@davvd
Copy link

davvd commented May 27, 2016

@davvd this is urgent

@krzyk got it, "urgent" label here

vkuchyn added a commit to vkuchyn/qulice that referenced this issue May 31, 2016
vkuchyn added a commit to vkuchyn/qulice that referenced this issue May 31, 2016
vkuchyn added a commit to vkuchyn/qulice that referenced this issue May 31, 2016
vkuchyn added a commit to vkuchyn/qulice that referenced this issue May 31, 2016
vkuchyn added a commit to vkuchyn/qulice that referenced this issue May 31, 2016
vkuchyn added a commit to vkuchyn/qulice that referenced this issue May 31, 2016
@krzyk
Copy link
Collaborator Author

krzyk commented Jun 1, 2016

@vkuchyn thanks

@krzyk krzyk closed this as completed Jun 1, 2016
@vkuchyn
Copy link
Contributor

vkuchyn commented Jun 1, 2016

@davvd was merged and fixed in #753

@davvd
Copy link

davvd commented Jun 2, 2016

@davvd was merged and fixed in #753

@vkuchyn thank you!

@davvd
Copy link

davvd commented Jun 2, 2016

@vkuchyn Thanks a lot, I just topped your account for 30 mins, transaction ID 88636738, total time was 1894 hours and 7 mins; +30 to your rating, your total score is +90

@krzyk
Copy link
Collaborator Author

krzyk commented Jun 28, 2016

@davvd this is not urgent

@davvd
Copy link

davvd commented Jun 28, 2016

@davvd this is not urgent

@krzyk got it, "urgent" tag removed from here

@davvd davvd removed the urgent label Jun 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants