PMD's AvoidDuplicateLiterals is not equivalent to original MultipleStringLiteralsCheck

[mkordas]

In Qulice 0.16.4 AvoidDuplicateLiterals took over MultipleStringLiteralsCheck. However, these checks are not fully equivalent.

MultipleStringLiteralsCheck was by default ignoring duplicates in annotations, see http://checkstyle.sourceforge.net/config_coding.html#MultipleStringLiterals. AvoidDuplicateLiterals doesn't do that, but it should, as it doesn't make sense to extract strings used in annotations to constants, especially if they are e.g. PMD exclusions.

Let's tune AvoidDuplicateLiterals to allow duplicates in annotations.

[krzyk]

@davvd valid bug

[krzyk]

@mkordas thanks

[davvd]

@davvd valid bug

@krzyk I added bug tag to this ticket

[davvd]

@mkordas thank you for the ticket reported, I topped your account for 15 mins, transaction 570ca198dd526211c100028f

[xupyprmv]

@krzyk Can this issue being resolved soon?

[krzyk]

@xupyprmv let's see

[krzyk]

@davvd this is urgent

[xupyprmv]

@krzyk Great thanks

[davvd]

@davvd this is urgent

@krzyk got it, "urgent" label here

[davvd]

@dskalenko this task is for you, keep these principles in mind, and don't hesitate to ask any technical questions; The budget of this issue is 30 mins, which is exactly how much will be paid when the task is done (see this for explanation)

[dskalenko]

@davvd here my PR #792

[davvd]

@davvd here my PR #792

@dskalenko thank you!

[dskalenko]

@mkordas Could you please close the task

[krzyk]

@davvd this is not urgent

[davvd]

@davvd this is not urgent

@krzyk OK, I un-labeled it as "urgent" tag

[davvd]

@dskalenko I just added 30 mins to your account, many thanks for your contribution (95742106).. 75 hours and 12 mins spent here; +30 added to your rating, current score is: +90