Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkstyle and PMD rules overlap #772

Closed
krzyk opened this issue May 25, 2016 · 29 comments
Closed

Checkstyle and PMD rules overlap #772

krzyk opened this issue May 25, 2016 · 29 comments

Comments

@krzyk
Copy link
Collaborator

krzyk commented May 25, 2016

Following checkstyle rules are equivalent of our PMD rules:

Checkstyle PMD
JavaNCSS (method and class) NcssMethodCount, NcssConstructorCount, NcssTypeCount
CyclomaticComplexity CyclomaticComplexity, StdCyclomaticComplexity, ModifiedCyclomaticComplexity
NPathComplexity NPathComplexity
MethodLength ExcessiveMethodLength
IllegalCatch AvoidCatchingGenericException
UnusedImports UnusedImports
FinalLocalVariableCheck LocalVariableCouldBeFinal

Please remove the checkstyle ones and make sure that PMD ones have at least the same threshold as the removed checkstyle checks (that is, we don't reduce code quality).

@krzyk
Copy link
Collaborator Author

krzyk commented May 25, 2016

@davvd valid bug

@davvd
Copy link

davvd commented May 25, 2016

@davvd valid bug

@krzyk I added bug tag to this ticket

@davvd davvd added the bug label May 25, 2016
@davvd
Copy link

davvd commented May 25, 2016

@krzyk many thanks for the bug report, I added 30 mins to your acc, transaction 87842351

@krzyk
Copy link
Collaborator Author

krzyk commented Aug 5, 2016

@davvd this is postponed

@davvd davvd added the postponed label Aug 5, 2016
@davvd
Copy link

davvd commented Aug 5, 2016

@davvd this is postponed

@krzyk OK, I put "postponed" label here

@davvd
Copy link

davvd commented Aug 5, 2016

@davvd this is postponed

@krzyk right, I will find someone else, no problem

@krzyk
Copy link
Collaborator Author

krzyk commented May 1, 2018

@0crat in

@0crat 0crat added the scope label May 1, 2018
@0crat
Copy link
Collaborator

0crat commented May 1, 2018

@0crat in (here)

@krzyk Job #772 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented May 1, 2018

Bug was reported, see §29: +15 point(s) just awarded to @krzyk/z

@0crat
Copy link
Collaborator

0crat commented May 1, 2018

@krzyk/z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented May 6, 2018

@krzyk/z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented May 11, 2018

@krzyk/z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented May 17, 2018

@krzyk/z everybody who has role DEV are banned at #772; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented May 22, 2018

@krzyk/z everybody who has role DEV is banned at #772; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented May 27, 2018

@krzyk/z everybody who has role DEV is banned at #772; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Jun 1, 2018

@krzyk/z everybody who has role DEV is banned at #772; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Jun 6, 2018

@krzyk/z everybody who has role DEV is banned at #772; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Jun 11, 2018

@krzyk/z everybody who has role DEV is banned at #772; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@krzyk
Copy link
Collaborator Author

krzyk commented Nov 30, 2018

@paulodamaso If you have some free time, this issue is quite frustrating

@paulodamaso
Copy link
Contributor

@krzyk I'm on it

@krzyk
Copy link
Collaborator Author

krzyk commented Nov 30, 2018

@0crat assign @paulodamaso

@0crat
Copy link
Collaborator

0crat commented Nov 30, 2018

@0crat assign @paulodamaso (here)

@krzyk The job #772 assigned to @paulodamaso/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@0crat
Copy link
Collaborator

0crat commented Nov 30, 2018

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @krzyk/z

@krzyk
Copy link
Collaborator Author

krzyk commented Dec 3, 2018

@paulodamaso thanks

@krzyk krzyk closed this as completed Dec 3, 2018
@0crat
Copy link
Collaborator

0crat commented Dec 3, 2018

@ypshenychka/z please review this job completed by @paulodamaso/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label Dec 3, 2018
@0crat
Copy link
Collaborator

0crat commented Dec 3, 2018

The job #772 is now out of scope

@ypshenychka
Copy link

@0crat quality good

@0crat
Copy link
Collaborator

0crat commented Dec 3, 2018

Order was finished, quality is "good": +35 point(s) just awarded to @paulodamaso/z

@0crat
Copy link
Collaborator

0crat commented Dec 3, 2018

Quality review completed: +8 point(s) just awarded to @ypshenychka/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants