DiamondOperator complains when instantiating/assigning inner types

[carlosmiranda]

DiamondOperator complains when you instantiate and assign an inner class type. For example, see the following code which is typical when using the Takes framework:

    @Override
    public Response act(final Request req) throws IOException {
        final RqForm.Smart smart = new RqForm.Smart(new RqForm.Base(req));
        // rest of code
    }

Qulice will complain about this:

[INFO] Checkstyle: src/test/java/com/xockets/xjm/http/TkAppTest.java[96]: Use diamond operator (DiamondOperatorCheck)

Note that RqForm.Smart is NOT a generic type, and neither are its parent types RqForm or Request. There is no way that the diamond operator can be applied here.

[krzyk]

@davvd valid bug

[krzyk]

@carlosmiranda thanks

[davvd]

@davvd valid bug

@krzyk tag "bug" added

[davvd]

@carlosmiranda many thanks for the report, I topped your account for 15 mins, transaction 89309942

[krzyk]

@davvd this is urgent

[davvd]

@davvd this is urgent

@krzyk sure, thanks, I added "urgent" label to it

[davvd]

@dskalenko this task is for you, keep these principles in mind, and don't hesitate to ask any technical questions. The budget of this issue is 30 mins, which is exactly how much will be paid when the task is done (see this for explanation)

[dskalenko]

@davvd I need more time to fix this issue, thanks for understanding

[davvd]

@davvd I need more time to fix this issue, thanks for understanding

@dskalenko sure, take your time

[dskalenko]

@davvd here my PR #789

[davvd]

@davvd here my PR #789

@dskalenko thanks

[krzyk]

@dskalenko now you have to ask the issue creator to close it

[carlosmiranda]

@dskalenko thanks!

[krzyk]

@davvd this is not urgent

[davvd]

@davvd this is not urgent

@krzyk got it, "urgent" tag removed from here

[davvd]

@dskalenko thanks, paid, 30 mins to your account, payment ID is 95473345, task took 1148 hours and 22 mins to complete... +30 to your rating, your total score is +60

[caarlos0]

@krzyk can you release it plz?

[krzyk]

@caarlos0 it was released on 0.17.1