Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's upgrade checkstyle and PMD to the latest versions and qulice to java 8 #880

Closed
krzyk opened this issue Apr 27, 2018 · 24 comments
Closed
Assignees

Comments

@krzyk
Copy link
Collaborator

krzyk commented Apr 27, 2018

Right now the latest version of checkstyle is 8.9 and for PMD it is 6.2.0.
One important fix in checkstyle is fix for RequireThis check, which reported false positives for constants in classes - ValidAbbreviationAsWordInName needed to be modified to work around this.

Also note that from checkstyle 7 java 8 is required to use it.
So we need to upgrade qulice to java 8 also.

@krzyk
Copy link
Collaborator Author

krzyk commented Apr 27, 2018

@yegor256 Are you OK with upgrading qulice to Java 8?
Java 7 is not currently supported by travis and also we would be limited to checkstyle version 6.19.

@krzyk
Copy link
Collaborator Author

krzyk commented Apr 28, 2018

@yegor256 ping

@krzyk
Copy link
Collaborator Author

krzyk commented May 3, 2018

@yegor256 Do you have any objections in making qulice require java 8? This would allow us to upgrade to the newest checkstyle (which requires java 8).

@yegor256
Copy link
Owner

yegor256 commented May 10, 2018

@krzyk I agree, let's upgrade to Java 8

@krzyk
Copy link
Collaborator Author

krzyk commented May 10, 2018

@0crat in

@0crat 0crat added the scope label May 10, 2018
@0crat
Copy link
Collaborator

0crat commented May 10, 2018

@0crat in (here)

@krzyk Job #880 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented May 10, 2018

Bug was reported, see §29: +15 point(s) just awarded to @krzyk/z

@0crat
Copy link
Collaborator

0crat commented May 10, 2018

@krzyk/z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented May 15, 2018

@krzyk/z everybody who has role DEV are banned at #880; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented May 20, 2018

@krzyk/z everybody who has role DEV are banned at #880; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented May 25, 2018

@krzyk/z everybody who has role DEV is banned at #880; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented May 30, 2018

@krzyk/z everybody who has role DEV is banned at #880; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Jun 4, 2018

@krzyk/z everybody who has role DEV is banned at #880; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Jun 10, 2018

@krzyk/z everybody who has role DEV is banned at #880; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Jun 15, 2018

@krzyk/z everybody who has role DEV is banned at #880; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Jun 20, 2018

@krzyk/z everybody who has role DEV is banned at #880; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@krzyk
Copy link
Collaborator Author

krzyk commented Aug 13, 2018

@0crat assign me

@0crat
Copy link
Collaborator

0crat commented Aug 13, 2018

@0crat assign me (here)

@krzyk The job #880 assigned to @krzyk/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@0crat
Copy link
Collaborator

0crat commented Aug 13, 2018

It is strongly discouraged to assign jobs to their creators, see §19: -15 point(s) just awarded to @krzyk/z

@0crat
Copy link
Collaborator

0crat commented Aug 13, 2018

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @krzyk/z

@krzyk
Copy link
Collaborator Author

krzyk commented Aug 13, 2018

@krzyk fixed in #924

@krzyk krzyk closed this as completed Aug 13, 2018
@0crat
Copy link
Collaborator

0crat commented Aug 13, 2018

Job was finished in 0 hours, bonus for fast delivery is possible (see §36)

@0crat 0crat removed the scope label Aug 13, 2018
@0crat
Copy link
Collaborator

0crat commented Aug 13, 2018

Order was finished: +35 point(s) just awarded to @krzyk/z

@0crat
Copy link
Collaborator

0crat commented Aug 13, 2018

The job #880 is now out of scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants