Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visit package definitions in MultilineJavadocTagsCheck #1271

Merged
merged 2 commits into from
May 15, 2024

Conversation

MikailBag
Copy link
Contributor

Should fix #1072

@MikailBag MikailBag marked this pull request as ready for review May 10, 2024 19:34
@pnatashap
Copy link
Contributor

@MikailBag it is good to have tests for the change to understand the reason for the change

@MikailBag MikailBag force-pushed the pkg-info-javadoc-check branch 2 times, most recently from 1355808 to 1f63462 Compare May 13, 2024 13:59
@MikailBag
Copy link
Contributor Author

@pnatashap I updated test so that it contains a PACKAGE_DEV token. Manual testing shows that it is emitted in package-info.java as well

$ cat package-info.java 
package foo.bar;
$ java -jar checkstyle-10.16.0-all.jar  -t package-info.java 
COMPILATION_UNIT -> COMPILATION_UNIT [1:0]
`--PACKAGE_DEF -> package [1:0]
    |--ANNOTATIONS -> ANNOTATIONS [1:11]
    |--DOT -> . [1:11]
    |   |--IDENT -> foo [1:8]
    |   `--IDENT -> bar [1:12]
    `--SEMI -> ; [1:15]

Copy link
Contributor

@pnatashap pnatashap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid formatting this comment also should be added to test to make sure that we do not raise error on it

@MikailBag
Copy link
Contributor Author

Thank you for comment, I've added a doc-comment to Valid.java.

Copy link
Contributor

@pnatashap pnatashap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@pnatashap
Copy link
Contributor

@yegor256 please take a look

@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented May 15, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit d28127a into yegor256:master May 15, 2024
8 checks passed
@rultor
Copy link
Collaborator

rultor commented May 15, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 12min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultilineJavadocTagsCheck in package-info.java
4 participants