-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#337 Provided integration with ant #361
Conversation
Thanks for the pull request, let me find a reviewer.. |
added "file:" prefix for License path
@davvd PR is stable, please find a reviewer. |
1 similar comment
@davvd PR is stable, please find a reviewer. |
@carlosmiranda this pull request is for you, please review |
@@ -0,0 +1,27 @@ | |||
Copyright (c) 2011-2014, Qulice.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use 2011-2015
copyright dates.
@carlosmiranda please have a look one more time. |
@rultor merge please |
@carlosmiranda Thanks for your request. @yegor256 Please confirm this. |
@rultor merge this |
@alevohin it's a huge branch, try to avoid them. Even though the code looks good, it's difficult to review it and very easy to miss something. A perfect branch modifies 30-40 lines of code and that's it. Read this by the way: http://blog.ploeh.dk/2015/01/15/10-tips-for-better-pull-requests/ |
<project name="Qulice" basedir="." default="qulice"> | ||
<taskdef name="qulice" | ||
classname="com.qulice.ant.QuliceTask" | ||
classpath="${com.qulice:qulice-ant:jar}"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rultor is complaining about this line. See http://www.rultor.com/t/1702-70933252.
@alevohin Rultor returned an error while trying to render the generated site. Please try executing |
@rultor Let's try to merge again please |
@carlosmiranda Thanks for your request. @yegor256 Please confirm this. |
@rultor try to merge again |
@yegor256 could you make release/deploy? |
@rultor release, tag is |
@yegor256 maybe deploy it to to repository too? |
@carlosmiranda Thanks for your contribution, 20 mins was added to your account, payment ID is +20 added to your rating, current score is: +2151 |
@rultor deploy |
Issue #337 Provided integration with ant