Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#337 Provided integration with ant #361

Merged
merged 21 commits into from
Jan 22, 2015
Merged

Conversation

alevohin
Copy link

@alevohin alevohin commented Jan 4, 2015

Issue #337 Provided integration with ant

@alevohin alevohin changed the title Issue337 Provided integration with ant #337 Provided integration with ant Jan 6, 2015
@davvd
Copy link

davvd commented Jan 7, 2015

Thanks for the pull request, let me find a reviewer..

@davvd davvd added CR labels Jan 7, 2015
added "file:" prefix for License path
@alevohin
Copy link
Author

alevohin commented Jan 8, 2015

@davvd PR is stable, please find a reviewer.

1 similar comment
@alevohin
Copy link
Author

@davvd PR is stable, please find a reviewer.

@alevohin
Copy link
Author

@davvd @yegor256 we need someone to review this PR.

@davvd
Copy link

davvd commented Jan 19, 2015

@carlosmiranda this pull request is for you, please review

@@ -0,0 +1,27 @@
Copyright (c) 2011-2014, Qulice.com
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use 2011-2015 copyright dates.

@alevohin
Copy link
Author

@carlosmiranda please have a look one more time.

@carlosmiranda
Copy link
Contributor

@rultor merge please

@rultor
Copy link
Collaborator

rultor commented Jan 21, 2015

@rultor merge please

@carlosmiranda Thanks for your request. @yegor256 Please confirm this.

@yegor256
Copy link
Owner

@rultor merge this

@rultor
Copy link
Collaborator

rultor commented Jan 21, 2015

@rultor merge this

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@yegor256
Copy link
Owner

@alevohin it's a huge branch, try to avoid them. Even though the code looks good, it's difficult to review it and very easy to miss something. A perfect branch modifies 30-40 lines of code and that's it. Read this by the way: http://blog.ploeh.dk/2015/01/15/10-tips-for-better-pull-requests/

@rultor
Copy link
Collaborator

rultor commented Jan 21, 2015

@rultor merge this

@yegor256 Oops, I failed. You can see the full log here (spent 16min)

<project name="Qulice" basedir="." default="qulice">
<taskdef name="qulice"
classname="com.qulice.ant.QuliceTask"
classpath="${com.qulice:qulice-ant:jar}"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rultor is complaining about this line. See http://www.rultor.com/t/1702-70933252.

@carlosmiranda
Copy link
Contributor

@alevohin Rultor returned an error while trying to render the generated site. Please try executing mvn clean site on your local build.

@alevohin
Copy link
Author

@yegor256 @alevohin index.apt.vm was fixed and checked. Please have a look one more time. PR is huge ( It's one of my first tasks, currently I try to avoid such huge branch.

@carlosmiranda
Copy link
Contributor

@rultor Let's try to merge again please

@rultor
Copy link
Collaborator

rultor commented Jan 22, 2015

@rultor Let's try to merge again please

@carlosmiranda Thanks for your request. @yegor256 Please confirm this.

@yegor256
Copy link
Owner

@rultor try to merge again

@rultor
Copy link
Collaborator

rultor commented Jan 22, 2015

@rultor try to merge again

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit a28c653 into yegor256:master Jan 22, 2015
@rultor
Copy link
Collaborator

rultor commented Jan 22, 2015

@rultor try to merge again

@yegor256 Done! FYI, the full log is here (took me 15min)

@alevohin
Copy link
Author

@yegor256 could you make release/deploy?

@yegor256
Copy link
Owner

@rultor release, tag is 0.12.1

@rultor
Copy link
Collaborator

rultor commented Jan 22, 2015

@rultor release, tag is 0.12.1

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Jan 22, 2015

@rultor release, tag is 0.12.1

@yegor256 Done! FYI, the full log is here (took me 28min)

@alevohin
Copy link
Author

@yegor256 maybe deploy it to to repository too?

@alevohin alevohin deleted the issue337 branch January 23, 2015 06:55
@davvd
Copy link

davvd commented Jan 23, 2015

@carlosmiranda Thanks for your contribution, 20 mins was added to your account, payment ID is 50617790

+20 added to your rating, current score is: +2151

@davvd
Copy link

davvd commented Jan 23, 2015

@rultor deploy

@rultor
Copy link
Collaborator

rultor commented Jan 23, 2015

@rultor deploy

@davvd OK, I'll try to deploy now. You can check the progress here

@rultor
Copy link
Collaborator

rultor commented Jan 23, 2015

@rultor deploy

@davvd Done! FYI, the full log is here (took me 11min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants