Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#448 fixed NPE problem in Maven Env #452

Merged
merged 1 commit into from
Aug 11, 2015
Merged

#448 fixed NPE problem in Maven Env #452

merged 1 commit into from
Aug 11, 2015

Conversation

krzyk
Copy link
Collaborator

@krzyk krzyk commented Aug 8, 2015

#448

  • recreated problem in integration test (using a dependency that has the <relocation> in pom)
  • <relocation> tag was causing NPE (this dependency doesn't have a jar) - fixed by checking if artifact has a file associated

@krzyk krzyk mentioned this pull request Aug 8, 2015
@davvd
Copy link

davvd commented Aug 11, 2015

@krzyk Thanks, I will find someone to review this PR soon

@davvd
Copy link

davvd commented Aug 11, 2015

@carlosmiranda review this one,please

@carlosmiranda
Copy link
Contributor

@rultor good to merge

@rultor
Copy link
Collaborator

rultor commented Aug 11, 2015

@rultor good to merge

@carlosmiranda Thanks for your request. @yegor256 Please confirm this.

@yegor256
Copy link
Owner

@rultor try to merge

@rultor
Copy link
Collaborator

rultor commented Aug 11, 2015

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 774b760 into yegor256:master Aug 11, 2015
@rultor
Copy link
Collaborator

rultor commented Aug 11, 2015

@rultor try to merge

@yegor256 Done! FYI, the full log is here (took me 17min)

@krzyk
Copy link
Collaborator Author

krzyk commented Aug 11, 2015

@rultor deploy pls

@rultor
Copy link
Collaborator

rultor commented Aug 11, 2015

@rultor deploy pls

@krzyk Thanks for your request. @yegor256 Please confirm this.

@davvd davvd added CR labels Aug 11, 2015
@yegor256
Copy link
Owner

@rultor deploy

@yegor256
Copy link
Owner

@rultor release tag is 0.12.2

@rultor
Copy link
Collaborator

rultor commented Aug 11, 2015

@rultor deploy

@yegor256 OK, I'll try to deploy now. You can check the progress here

@rultor
Copy link
Collaborator

rultor commented Aug 11, 2015

@rultor deploy

@yegor256 Done! FYI, the full log is here (took me 11min)

@rultor
Copy link
Collaborator

rultor commented Aug 11, 2015

@rultor release tag is 0.12.2

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Aug 11, 2015

@rultor release tag is 0.12.2

@yegor256 Done! FYI, the full log is here (took me 14min)

@davvd davvd added CR labels Aug 11, 2015
@davvd
Copy link

davvd commented Aug 12, 2015

@carlosmiranda done, I added 16 mins in payment 62980440, 1 hour and 24 mins spent to complete this... review comments (c=1) added as a bonus... +16 added to your rating, current score is: +3254

@davvd
Copy link

davvd commented Aug 12, 2015

@rultor please deploy

@rultor
Copy link
Collaborator

rultor commented Aug 12, 2015

@rultor please deploy

@davvd OK, I'll try to deploy now. You can check the progress here

@rultor
Copy link
Collaborator

rultor commented Aug 12, 2015

@rultor please deploy

@davvd Done! FYI, the full log is here (took me 12min)

@krzyk krzyk deleted the 448 branch October 10, 2015 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants