Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#469 fixed xml formatting problems #481

Merged
merged 1 commit into from
Oct 19, 2015
Merged

#469 fixed xml formatting problems #481

merged 1 commit into from
Oct 19, 2015

Conversation

krzyk
Copy link
Collaborator

@krzyk krzyk commented Oct 17, 2015

#469

  • fixed problem with XML preambule (now it is required, including encoding)
  • fixed problem with comment before the first XML tag
  • fixed problem with new line at the and of XML (it is required now)
  • added todo to fix incorrect attribute formatting

@caarlos0
Copy link
Contributor

@krzyk Looks good!

@davvd
Copy link

davvd commented Oct 19, 2015

@krzyk Let me find a reviewer for this pull request, thanks for submitting it

@davvd
Copy link

davvd commented Oct 19, 2015

@yegor256 this pull request is for you, please review

@yegor256
Copy link
Owner

@rultor try to merge

@rultor
Copy link
Collaborator

rultor commented Oct 19, 2015

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 2908f42 into yegor256:master Oct 19, 2015
@rultor
Copy link
Collaborator

rultor commented Oct 19, 2015

@rultor try to merge

@yegor256 Done! FYI, the full log is here (took me 13min)

@davvd davvd added CR labels Oct 20, 2015
@davvd
Copy link

davvd commented Oct 21, 2015

@yegor256 Much obliged! I have added 16 mins to your account in payment "000-e207982c", 24 hours and 12 mins spent. review comments (c=1) added as a bonus. +16 added to your rating, at the moment it is: +10751

@davvd
Copy link

davvd commented Oct 21, 2015

@rultor please deploy

@rultor
Copy link
Collaborator

rultor commented Oct 21, 2015

@rultor please deploy

@davvd OK, I'll try to deploy now. You can check the progress here

@rultor
Copy link
Collaborator

rultor commented Oct 21, 2015

@rultor please deploy

@davvd Done! FYI, the full log is here (took me 12min)

@caarlos0
Copy link
Contributor

caarlos0 commented Nov 1, 2015

@davvd can we release this change?

@davvd
Copy link

davvd commented Nov 3, 2015

@davvd can we release this change?

@caarlos0 ask @krzyk, he is the architect

@krzyk
Copy link
Collaborator Author

krzyk commented Nov 3, 2015

@rultor release tag is 0.13.1

@rultor
Copy link
Collaborator

rultor commented Nov 3, 2015

@rultor release tag is 0.13.1

@krzyk OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Nov 3, 2015

@rultor release tag is 0.13.1

@krzyk Done! FYI, the full log is here (took me 16min)

@krzyk
Copy link
Collaborator Author

krzyk commented Nov 3, 2015

@caarlos0 done, you can use 0.13.1 now

@caarlos0
Copy link
Contributor

caarlos0 commented Nov 3, 2015

@krzyk thanks!

@krzyk krzyk deleted the 469 branch November 16, 2015 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants